Mirror magni_robot in loki_robot #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step in resolving issue #1
ghost
added
the
jim-v
suggested changes
Dec 27, 2017
| <launch> | ||
| <arg name="gui" default="False" /> | ||
| <param name="use_gui" value="$(arg gui)"/> | ||
| <param name="robot_description" textfile="$(find magni_description)/urdf/loki.urdf" /> |
There was a problem hiding this comment.
Seems to reference magni_description directory
There was a problem hiding this comment.
Fixed, also greped for magni and removed all references to it.
jim-v
approved these changes
Dec 27, 2017
you need to use exec_depend on all the subpackages in the metapackage otherwise the installing the metapackage won't pull in the others
|
Tested on real hardware: teleop works, sonars come up, and urdf renders in rviz.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
This should significantly simplify the whole loki setup situation from the mess it is right now.
It still isn't ideal because of all the code duplication, but we can work on fixing that.
Please look for any errors, as I probably screwed up somewhere, and I haven't tested this on anything.