Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in fid len #116

Merged
merged 2 commits into from May 18, 2021
Merged

Pass in fid len #116

merged 2 commits into from May 18, 2021

Conversation

rohbotics
Copy link
Member

This allows you to specify the fiducial length from the command line.

roslaunch magni_demos simple_navigation.launch fiducial_len:=0.200

@rohbotics rohbotics requested a review from mjstn May 18, 2020 20:38
@rohbotics rohbotics self-assigned this May 18, 2020
@mjstn
Copy link
Contributor

mjstn commented May 22, 2020

Oh, I just saw this. I thought you said you had just done it already. Ok, I'll look, thanks.

Copy link
Contributor

@mjstn mjstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing the review. This has helped me pass down args to fiducial_slam and resolved my questions there I had for you earlier.

@JanezCim
Copy link
Contributor

JanezCim commented Apr 6, 2021

Is this still in need of another review or can we close this PR?

@rohbotics rohbotics merged commit 92ffa54 into indigo-devel May 18, 2021
@rohbotics rohbotics deleted the pass-in-fid-len branch July 21, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants