Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only exec_depend to avoid pulling in unnecessary dependencies at build-time #46

Merged
merged 2 commits into from Dec 23, 2017

Conversation

Projects
None yet
2 participants
@rohbotics
Copy link
Member

commented Dec 23, 2017

Fixes #45

Also make the package.xml files more consistent.

I will run a release after this is merged, and then report on the build time improvement. (Currently it takes 1hr 20min, most of which is pulling deps).

@rohbotics rohbotics added the in review label Dec 23, 2017

@rohbotics rohbotics self-assigned this Dec 23, 2017

@rohbotics rohbotics requested a review from jim-v Dec 23, 2017

@jim-v

jim-v approved these changes Dec 23, 2017

@rohbotics rohbotics merged commit 365b74a into indigo-devel Dec 23, 2017

@ghost ghost removed the in review label Dec 23, 2017

@rohbotics

This comment has been minimized.

Copy link
Member Author

commented Dec 26, 2017

For completeness the build is now down to 36 minutes with this PR.

@rohbotics rohbotics deleted the fix-#45 branch Dec 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.