fix(progress-button): fix styling & add playground page #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiubologa
commented
Aug 16, 2023
...cts/angular/directives/ui-progress-button/src/internal/ui-button-progress-bar.component.scss
Show resolved
Hide resolved
anatolie-darii
previously approved these changes
Aug 16, 2023
ioanajoj
previously approved these changes
Aug 16, 2023
LiviuTrifoi
reviewed
Aug 16, 2023
| ui-button-progress-bar { | ||
| display: block; | ||
| width: 100%; | ||
| width: 0; |
Member
Author
There was a problem hiding this comment.
so it doesn't occupy space inside the button
sergiubologa
dismissed stale reviews from ioanajoj and anatolie-darii
via
d82d630
sergiubologa
requested review from
LiviuTrifoi,
anatolie-darii,
anbalase and
ioanajoj
sergiubologa
force-pushed
the
fix/ui-progress-button-ang-15
branch
from
72c880c to
4c7aeb8
Compare
|
Code Climate has analyzed commit 4c7aeb8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.7% (0.0% change). View more on Code Climate. |
anbalase
approved these changes
Aug 16, 2023
gheorghitahurmuz
pushed a commit
that referenced
this pull request
Dec 12, 2023
fix(progress-button): fix styling & add playground page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
