Skip to content

Conversation

@dan-mirescu
Copy link
Contributor

Reduce the height of ui-suggest when no results are found and customItemSize is used.

https://uipath.atlassian.net/browse/OR-65722

@dan-mirescu dan-mirescu requested a review from a team September 4, 2023 14:04
@dan-mirescu dan-mirescu self-assigned this Sep 4, 2023
@dan-mirescu dan-mirescu requested review from Gabriela-David and alexdudescu and removed request for a team September 4, 2023 14:04
@dan-mirescu dan-mirescu force-pushed the fix/ui-suggest-remove-empty-space branch 2 times, most recently from 1200b49 to aa7579d Compare September 5, 2023 09:33
@dan-mirescu dan-mirescu changed the title 🚧 fix(suggest): reduce height of ui-suggest when no results found fix(suggest): reduce height of ui-suggest when no results found Sep 5, 2023
Copy link
Collaborator

@anbalase anbalase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need this for 14 as well, right?

@dan-mirescu
Copy link
Contributor Author

dan-mirescu commented Sep 6, 2023

For 14: #393

@dan-mirescu dan-mirescu force-pushed the fix/ui-suggest-remove-empty-space branch from aa7579d to a424d24 Compare September 6, 2023 11:57
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit a424d24 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.7% (0.0% change).

View more on Code Climate.

@dan-mirescu dan-mirescu merged commit 4069ede into master Sep 8, 2023
@dan-mirescu dan-mirescu deleted the fix/ui-suggest-remove-empty-space branch September 8, 2023 11:28
gheorghitahurmuz pushed a commit that referenced this pull request Dec 12, 2023
fix(suggest): reduce height of ui-suggest when no results found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants