New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to parse IP target list from text file #169

Closed
joaoantonio87 opened this Issue Mar 5, 2018 · 11 comments

Comments

4 participants
@joaoantonio87

joaoantonio87 commented Mar 5, 2018

Is It possible to create a TXT file with multiple Ip's and execute a massive scan? Thz

@Ullaakut

This comment has been minimized.

Owner

Ullaakut commented Mar 5, 2018

Hi @joaoantonio87 !

It's on my list of potential features, so since you need it I will add it to the project board and I will work on it when I find the time to. If you want it quickly, I can give you advice and help on how to code it and contribute to this repository! :)

Thanks for using Cameradar 🎉

@Ullaakut Ullaakut changed the title from Multiple Ip's scans to Add feature to parse IP target list from text file Mar 5, 2018

@Ullaakut Ullaakut added this to To do in Cameradar v2.0.0 Mar 5, 2018

@Ullaakut

This comment has been minimized.

Owner

Ullaakut commented Jun 16, 2018

#83 blocks this issue.

@Ullaakut Ullaakut added the blocked label Jun 16, 2018

@Furl0w

This comment has been minimized.

Furl0w commented Jun 17, 2018

I just started to work on this as my first issue in go sadface.jpg
I'll look the other issues

@Ullaakut

This comment has been minimized.

Owner

Ullaakut commented Jun 18, 2018

Ah damn, you should have written something I'd have attributed it to you. I already implemented a fix for #83 and the feature for this issue on my machine, PR is almost ready.

If you'd like, still make the PR, I will push only the changes to fix #83 and we can go over your implementation of #169 together over your PR. How does that sound? :)

@Ullaakut

This comment has been minimized.

Owner

Ullaakut commented Jun 18, 2018

Otherwise, you can also work on #119 but we would need to talk together about how we measure progression, and it will probably be slightly more advanced. It can still be a good first issue, IMO.

@Furl0w

This comment has been minimized.

Furl0w commented Jun 18, 2018

I had just made the parser (take path of file and return array of valid ip as string) and since i have an issue when compiling the binary on my machine (problem with curl package) I haven't fixed yet i didn't want to claim the issue without being sure i could do it.
I think you can go with your PR for this issue, I'll compare with mine to see if i was on the good idea.
I'll look the other issue when I have time and when I manage to fix this compilation problem but yeah I'm interesting in working on this one if you're not in a big hurry.

@Ullaakut

This comment has been minimized.

Owner

Ullaakut commented Jun 19, 2018

Did you run dep ensure? Otherwise you won't have the packages you need to build the project. If you have trouble with all this, don't worry about compiling it yourself and just run docker build -t cameradar . to build the docker image from your version, and then launch a container using the docker image.

There's no hurry at all :) If you want, we can even pair prog it during a weekend, I'd be glad to help you get started with coding in Go.

@Furl0w

This comment has been minimized.

Furl0w commented Jun 22, 2018

Ok, the docker build works well (pretty sure i did use dep ensure, but i kept hitting an issue with a curl package used in go-curl when building the binary but whatever, the docker image is fine)
Sorry for not responding earlier the week has been rough but I'd be glad to pair prog someday :)
I'll try to finish this PR this week-end and then we'll look into the progression bar for #119

@Ullaakut Ullaakut moved this from To do to To be validated in Cameradar v2.0.0 Jul 6, 2018

@Ullaakut

This comment has been minimized.

Owner

Ullaakut commented Jul 22, 2018

Hi @Zuppadre, let me know if you made some progress :) The PR is only a QOL improvement so it's okay if the PR hangs for a while, but if you don't plan on working on it anymore please ping me 😉

@vdkotian

This comment has been minimized.

vdkotian commented Nov 11, 2018

Hey is this issue still open. I wanted to go ahead and contribute for this project.

@Ullaakut

This comment has been minimized.

Owner

Ullaakut commented Nov 12, 2018

Hi @vdkotian ! Unfortunately, this issue was hanging because @Furl0w was supposed to work on it but since I haven't had any news, and I already made the PR for it here.

I think I will just merge it now, since it's a feature that has even been requested to me by email recently.

In the meantime, I can suggest you take a look at #119 or #104.

#119 is basically going to be estimating the remaining time depending on which step cameradar is at, and also maybe even which step nmap is at if you're brave enough to parse nmap's logs. I'd recommend following the advice of @gaelduplessix on the issue by the way, which is to make nmap output to stdout instead of in a file, this will require a few minimal changes in the library.

#104 is simply for you to use cameradar a bit, get familiar with it, and make a simple tutorial on how to download it and use it (for a pure beginner's perspective, so it should include downloading docker as well)

Thanks again for wanting to contribute! 🎉

Ullaakut added a commit that referenced this issue Nov 12, 2018

#169 Parse target list from text file (#177)
* Add file parsing for targets & fix multi targets in docker

* Remove deprecated info in README & update examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment