modify test dependency to /v2, update doc badge #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn, sorry I keep messing this up 馃槄 Thanks for your help :)) |
Ullaakut
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with the v2 module (thanks!), the projects that pull this as dependency still show the previous version as indirect dependency (which is slightly confusing - "why is it still there?") due to the test having the old import. This PR changes the import in xml_test.go to the
/v2one, and also updates the documentation badge to point to pkg.go.dev - I believe godoc.org doesn't support the version > v2.I would appreciate if you could cut yet another (v2.0.2) release after you merge this 馃槃
Fixes #57