Insert gcode at layer change #4353

wporter82 · 2018-09-10T20:28:16Z

I needed the ability to manually send commands on layer change and couldn't find a solution so I made this one up to fill that need.

Add insert gcode at layer change to PostProcessingPlugin

Ghostkeeper · 2018-09-10T21:04:43Z

As seen on Reddit!

Developers, see issue CURA-5713.

Kriechi · 2018-09-11T09:18:43Z

@wporter82 I made a similar script to inject some instructions for timelapse creation with the Duet & RepRapFirmware. I think there is a good overlap - so maybe we can merge our approaches together! Let me know what you think!

Kriechi · 2018-09-11T09:22:48Z

@wporter82 oh - I see you also added a timelapse script (intentional in this PR?).
It would be nice to make the head-park optional - for the people with stringing issues who don't want to move just because of the webcam.

wporter82 · 2018-09-11T20:36:48Z

@Kriechi I have added the option for parking the head to be optional as well as looked at what your scripts were doing for the Duet. I added the wait for moves to finish but for the picture taking command, the default I have set is to use the Marlin code M240 but can be changed by the user to something like what you have.

Kriechi · 2018-09-12T09:23:44Z

plugins/PostProcessingPlugin/scripts/TimeLapse.py

+        gcode_to_append = self.putValue(M = 400) + ";Wait for moves to finish\n"
+        if park_print_head:
+	        gcode_to_append = self.putValue(G = 90) + ";Absolute positioning\n"
+        	gcode_to_append += self.putValue(G = 1, F = feed_rate, X = x_park, Y = y_park) + ";Park print head\n"


G90 vs. G91 is always tricky - I guess the users have to be aware at this point that using the park-print-head features switches to absolute positioning - and does not switch back.

Maybe add another M400 to wait for the parking move to be finished?

Kriechi · 2018-09-12T09:25:50Z

This looks good! If it gets merged I will change https://github.com/Kriechi/DuetRRF-timelapse to make use of this script once it is released with the next Cura version.

LipuFei · 2018-09-25T08:59:47Z

plugins/PostProcessingPlugin/scripts/TimeLapse.py

+
+        gcode_to_append = self.putValue(M = 400) + ";Wait for moves to finish\n"
+        if park_print_head:
+	        gcode_to_append = self.putValue(G = 90) + ";Absolute positioning\n"


This line and the next in this if block contain TABs as indents.

Signed-off-by: Wayne Porter <wporter82@gmail.com>

alekseisasin · 2018-10-17T12:19:26Z

@wporter82 , I have tried Before and After and all of them has the same output, did not see any difference.

alekseisasin · 2018-11-06T08:44:36Z

@wporter82 , do you still want to add this script?

dector · 2018-11-18T20:22:11Z

Let me insert my 50 cents here. 😄

I think that searching for the beginning of the layer in this way isn't good enough for cases when another script has already modified some layer and added its own code before ;LAYER. For example, you can add this script into post-processing queue twice and second one will not work as expected.

Case "adding gcode after layer" doesn't work as expected as well. As @alekseisasin already said, in current implementation it's the same as adding value before layer (we'll have redundant gcode instruction before the first layer and no instruction after the last one).

Some time ago I made something similar (but for adding gcode only before layer though) here. I can open another PR if @wporter82 will be absent for some time.

wporter82 · 2018-11-19T23:54:27Z

I agree with @dector in that this can cause problems if considerations are not taken. I've considered writing a complete plugin just for time lapse instead of going this route of basically find/replace. If this appears to cause more possible problems than it helps solve, I would think it should be abandoned for a better solution.

alekseisasin · 2018-11-21T18:34:51Z

Right, a solution which might introduce another issue is not a good scenario.
If will be no more effort done for this ticket then I suggest closing this issue.

diegopradogesto

Small suggested changes.

diegopradogesto · 2019-02-01T11:05:55Z

plugins/PostProcessingPlugin/scripts/InsertAtLayerChange.py

+            "version": 2,
+            "settings":
+            {
+                "insert_loc":


I would not abbreviate the setting name:

Suggested change

"insert_loc":

"insert_location":

diegopradogesto · 2019-02-01T11:06:16Z

plugins/PostProcessingPlugin/scripts/InsertAtLayerChange.py

+
+            if in_layer:
+                index = data.index(layer)
+                if self.getSettingValueByKey("insert_loc") == "before":


Suggested change

if self.getSettingValueByKey("insert_loc") == "before":

if self.getSettingValueByKey("insert_location") == "before":

diegopradogesto · 2019-02-01T11:46:05Z

plugins/PostProcessingPlugin/scripts/InsertAtLayerChange.py

+            else:
+                in_layer = False
+
+            if in_layer:


Suggestion: This can be simplified by using if ";LAYER:" in lines[0]: and remove the 4 previous layers.

diegopradogesto · 2019-02-01T11:46:45Z

plugins/PostProcessingPlugin/scripts/TimeLapse.py

+            "version": 2,
+            "settings":
+            {
+                "trigger_cmd":


Do not abbreviate setting name:

Suggested change

"trigger_cmd":

"trigger_command":

diegopradogesto · 2019-02-01T11:47:14Z

plugins/PostProcessingPlugin/scripts/TimeLapse.py

+        park_print_head = self.getSettingValueByKey("park_print_head")
+        x_park = self.getSettingValueByKey("head_park_x")
+        y_park = self.getSettingValueByKey("head_park_y")
+        trigger_cmd = self.getSettingValueByKey("trigger_cmd")


Suggested change

trigger_cmd = self.getSettingValueByKey("trigger_cmd")

trigger_command = self.getSettingValueByKey("trigger_command")

diegopradogesto · 2019-02-01T11:47:37Z

plugins/PostProcessingPlugin/scripts/TimeLapse.py

+        if park_print_head:
+            gcode_to_append += self.putValue(G = 1, F = feed_rate, X = x_park, Y = y_park) + ";Park print head\n"
+        gcode_to_append += self.putValue(M = 400) + ";Wait for moves to finish\n"
+        gcode_to_append += trigger_cmd + ";Snap Photo\n"


Suggested change

gcode_to_append += trigger_cmd + ";Snap Photo\n"

gcode_to_append += trigger_command + ";Snap Photo\n"

diegopradogesto · 2019-02-01T11:48:05Z

plugins/PostProcessingPlugin/scripts/TimeLapse.py

+            else:
+                in_layer = False
+
+            if in_layer:


Suggestion: This can be simplified by using if ";LAYER:" in lines[0]: and remove the 4 previous layers.

diegopradogesto · 2019-02-13T13:39:27Z

@wporter82 are you handling the suggested changes? No rush, only to know if we need to keep this in mind or not.

diegopradogesto · 2019-03-08T14:48:53Z

I did some changes here 9396628 and merged it since it was taking a lot of lead time.

Ghostkeeper · 2019-03-20T16:09:59Z

We might want to add the option to retract during the move towards the park location as well at some point...

wporter82 added 2 commits September 10, 2018 12:25

Add insert gcode at layer change to PostProcessingPlugin

2715a20

Merge pull request #1 from wporter82/wporter82-layer-change

d7d1c2b

Add insert gcode at layer change to PostProcessingPlugin

Add time lapse post processing plugin

74a6d31

wporter82 added 3 commits September 11, 2018 08:03

Move post processing scripts to correct location

256aef3

Make timelapse head parking optional

eb3670d

Add wait for moves to finish to timelapse script

2e77293

Kriechi reviewed Sep 12, 2018

View reviewed changes

Appesteijn added the Status: In Progress label Sep 24, 2018

LipuFei reviewed Sep 25, 2018

View reviewed changes

wporter82 added 5 commits September 26, 2018 11:24

Fix tab/space mixing

2502d47

Signed-off-by: Wayne Porter <wporter82@gmail.com>

Fix bug when parking nozzle

26bbf3e

Signed-off-by: Wayne Porter <wporter82@gmail.com>

Add beginning and end gcode comments

03c0faa

Signed-off-by: Wayne Porter <wporter82@gmail.com>

Remove G90 and assume absolute positioning

f3ad17a

Signed-off-by: Wayne Porter <wporter82@gmail.com>

Fix begin and end comments

821a4de

Signed-off-by: Wayne Porter <wporter82@gmail.com>

diegopradogesto suggested changes Feb 1, 2019

View reviewed changes

diegopradogesto merged commit 821a4de into Ultimaker:master Mar 8, 2019

Ellecross mentioned this pull request Dec 2, 2019

Time Lapse Cura 4.4 #6730

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Insert gcode at layer change #4353

Insert gcode at layer change #4353

wporter82 commented Sep 10, 2018

Ghostkeeper commented Sep 10, 2018

Kriechi commented Sep 11, 2018

Kriechi commented Sep 11, 2018

wporter82 commented Sep 11, 2018

Kriechi Sep 12, 2018

Kriechi Sep 12, 2018

Kriechi commented Sep 12, 2018

LipuFei Sep 25, 2018 •

edited

alekseisasin commented Oct 17, 2018

alekseisasin commented Nov 6, 2018

dector commented Nov 18, 2018

wporter82 commented Nov 19, 2018

alekseisasin commented Nov 21, 2018

diegopradogesto left a comment

diegopradogesto Feb 1, 2019

diegopradogesto Feb 1, 2019

diegopradogesto Feb 1, 2019

diegopradogesto Feb 1, 2019

diegopradogesto Feb 1, 2019

diegopradogesto Feb 1, 2019

diegopradogesto Feb 1, 2019

diegopradogesto commented Feb 13, 2019

diegopradogesto commented Mar 8, 2019

Ghostkeeper commented Mar 20, 2019 •

edited

	if self.getSettingValueByKey("insert_loc") == "before":
	if self.getSettingValueByKey("insert_location") == "before":

	trigger_cmd = self.getSettingValueByKey("trigger_cmd")
	trigger_command = self.getSettingValueByKey("trigger_command")

	gcode_to_append += trigger_cmd + ";Snap Photo\n"
	gcode_to_append += trigger_command + ";Snap Photo\n"

Insert gcode at layer change #4353

Insert gcode at layer change #4353

Conversation

wporter82 commented Sep 10, 2018

Ghostkeeper commented Sep 10, 2018

Kriechi commented Sep 11, 2018

Kriechi commented Sep 11, 2018

wporter82 commented Sep 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kriechi commented Sep 12, 2018

LipuFei Sep 25, 2018 • edited

Choose a reason for hiding this comment

alekseisasin commented Oct 17, 2018

alekseisasin commented Nov 6, 2018

dector commented Nov 18, 2018

wporter82 commented Nov 19, 2018

alekseisasin commented Nov 21, 2018

diegopradogesto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diegopradogesto commented Feb 13, 2019

diegopradogesto commented Mar 8, 2019

Ghostkeeper commented Mar 20, 2019 • edited

LipuFei Sep 25, 2018 •

edited

Ghostkeeper commented Mar 20, 2019 •

edited