Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: flow per print-feature #4561

Merged
merged 8 commits into from Jul 1, 2019

Conversation

@BagelOrb
Copy link
Member

BagelOrb commented Oct 12, 2018

frontend settings for Ultimaker/CuraEngine#874

@diegopradogesto

This comment has been minimized.

Copy link
Contributor

diegopradogesto commented Oct 17, 2018

CI is not passing due to you move the prime_tower_flow, so the expert settings list has to change.

@BagelOrb

This comment has been minimized.

Copy link
Member Author

BagelOrb commented Oct 17, 2018

I don't understand. The Jenkins link links to something which doesn't look like an error report.

What's the problem? What do you need me to do?

BagelOrb added 6 commits Oct 12, 2018
…ine width any more

They are not even in the same unit, so it cannot be a child.
A parent setting should be exactly equal to all child settings combined.
that's because we should override the per-feature flow settings with one global material_flow_layer_0 setting to rule them all.
The flow per feature is more accurate to these features, so the initial layer should expand all these seaprately.
@BagelOrb BagelOrb force-pushed the BagelOrb:feat_line_spacings branch from 8d9cf90 to 3699941 Oct 17, 2018
@diegopradogesto

This comment has been minimized.

Copy link
Contributor

diegopradogesto commented Oct 17, 2018

This is the error:
image

What you need to do is to move the prime_tower_flow entry in the file expert.cfg from the [dual] section to the [material] section. Also if the new settings are considered expert or advanced or basic, they should be added to the right file.

@BagelOrb

This comment has been minimized.

Copy link
Member Author

BagelOrb commented Oct 17, 2018

Ah thanks! I see where to find the error now.

Fixed it!
Made all flow settings on by default in expert settings.

(Minor remark: it's a bit weird that you have to specify the category in the default setting visibility file. I don;t really see the reason.)

@nallath

This comment has been minimized.

Copy link
Member

nallath commented Nov 2, 2018

CURA-5892

@cjp0008

This comment has been minimized.

Copy link

cjp0008 commented May 25, 2019

Any update on this?

@BagelOrb

This comment has been minimized.

Copy link
Member Author

BagelOrb commented May 27, 2019

+1

@Ghostkeeper

This comment has been minimized.

Copy link
Member

Ghostkeeper commented May 28, 2019

The Jira ticket says that it would be discussed with Ultimaker's Materials & Processing team. A few months ago I asked if this had happened yet but nobody seems to read that (and then I forgot about it too).

I don't know why the M&P team needs to get involved with this, really, other than by telling them that this is now an option, and they can use it if they like, or not if they don't like...

@cjp0008

This comment has been minimized.

Copy link

cjp0008 commented May 30, 2019

The Jira ticket says that it would be discussed with Ultimaker's Materials & Processing team. A few months ago I asked if this had happened yet but nobody seems to read that (and then I forgot about it too).

I don't know why the M&P team needs to get involved with this, really, other than by telling them that this is now an option, and they can use it if they like, or not if they don't like...

Ok, thanks for the info, yes it doesn't make much sense.... hopefully they will just add the functionality and then let the M&P team play around with it!

@nallath nallath merged commit 0b7b395 into Ultimaker:master Jul 1, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.