From f67cde8b28d42b5a112f7bd507f87a898d7b1612 Mon Sep 17 00:00:00 2001
From: David Stone <david@nnucomputerwhiz.com>
Date: Tue, 24 Mar 2026 16:02:43 -0600
Subject: [PATCH] fix: settings search navigation and title-based search (#311)

- Replace item_add handler in selectizer.js to use selectize.options[value]
  instead of iterating a custom savedItems array with a hardcoded 'setting_id'
  comparison. The options store is always populated when an item is added,
  making navigation reliable regardless of AJAX timing.

- Update search_wp_ultimo_setting() in class-ajax.php to search across
  setting_id, title, and desc fields (case-insensitive) instead of only
  setting_id. Users can now find settings by typing human-readable names
  like 'Company Name' rather than internal keys like 'company_name'.

- Update selectizer.min.js with equivalent minified change.
---
 assets/js/selectizer.js     | 26 ++++++++++-------------
 assets/js/selectizer.min.js |  2 +-
 inc/class-ajax.php          | 42 ++++++++++++++++++++++++++++++-------
 3 files changed, 46 insertions(+), 24 deletions(-)

diff --git a/assets/js/selectizer.js b/assets/js/selectizer.js
index edce18839..01ebeb220 100644
--- a/assets/js/selectizer.js
+++ b/assets/js/selectizer.js
@@ -172,21 +172,17 @@
 
 		selectize.on('item_add', function(value) {
 
-			let active_item = {
-				url: null,
-			};
-
-			jQuery.each(selectize.savedItems, function(index, item) {
-
-				if (item.setting_id === value) {
-
-					active_item = item;
-
-				} // end if;
-
-			});
-
-			if (active_item.url) {
+			/*
+			 * Look up the selected item directly from selectize's options store,
+			 * which is keyed by the valueField and is always populated when an
+			 * item is added. This replaces the previous approach of searching
+			 * through a custom savedItems array with a hardcoded 'setting_id'
+			 * field comparison, which failed when savedItems was not yet populated
+			 * or when the valueField differed from 'setting_id'.
+			 */
+			const active_item = selectize.options[ value ];
+
+			if (active_item && active_item.url) {
 
 				window.location.href = active_item.url;
 
diff --git a/assets/js/selectizer.min.js b/assets/js/selectizer.min.js
index 09034b0de..7511383d1 100644
--- a/assets/js/selectizer.min.js
+++ b/assets/js/selectizer.min.js
@@ -1 +1 @@
-(i=>{i(document).ready(function(){window.wu_initialize_selectizer=function(){i.each(i("[data-selectize]"),function(e,t){var t=jQuery(i(t)),a=t.find("option").length,l={};1e3<a&&(l.maxOptions=a+100),t.selectize(l)}),i.each(i("[data-selectize-categories]"),function(e,t){jQuery(i(t)).selectize({maxItems:i(t).data("max-items")||10,create(e){return{value:e,text:e}}})}),i.each(i("[data-model]"),function(e,t){wu_selector({el:t,valueField:i(t).data("value-field"),labelField:i(t).data("label-field"),searchField:i(t).data("search-field"),maxItems:i(t).data("max-items"),selected:i(t).data("selected"),options:[],data:{action:"wu_search",model:i(t).data("model"),number:10,exclude:i(t).data("exclude"),include:i(t).data("include")}})})},wu_initialize_selectizer(),jQuery("body").on("wubox:load",function(){wu_initialize_selectizer()})}),window.wu_selector=function(l){if(l=_.defaults(l,{options:[],maxItems:1,templateName:!1,create:!1}),jQuery(l.el).data("init"))return;jQuery(l.el).data("__options",l);let i=jQuery(l.el).selectize({valueField:l.valueField,labelField:l.labelField,searchField:["text","name","display_name","domain","path","title","desc","code","post_title","reference_code"],options:l.options,maxItems:l.maxItems,create:l.create,render:{option(e){var t=l.templateName||l.data.model,t=(jQuery("#wu-template-"+t).length?jQuery("#wu-template-"+t):jQuery("#wu-template-default")).html();return _.template(t,{interpolate:/\{\{(.+?)\}\}/g})(e)}},load(e,t){if(!e.length)return t();var a=jQuery(l.el).data("__options");jQuery.ajax({url:wu_selectizer.ajaxurl,type:"POST",data:{...a.data,query:{search:"*"+e+"*"}},error(){t()},success(e){d.savedItems=e,t(e)}})}}),d=(jQuery(l.el).attr("data-init",1),i[0].selectize);var e;d.on("change",function(e){var t=jQuery(i[0]),a=t.parents("[data-wu-app]").data("wu-app");a&&void 0!==window["wu_"+a]&&(window["wu_"+a][t.attr("name")]=e)}),d.on("item_add",function(a){let l={url:null};jQuery.each(d.savedItems,function(e,t){t.setting_id===a&&(l=t)}),l.url&&(window.location.href=l.url)}),l.selected&&(d.options=[],d.clearOptions(),e=_.isArray(l.selected)?l.selected:[l.selected],d.addOption(e),e=_.isArray(l.selected)?_.pluck(l.selected,l.valueField):l.selected[l.valueField],d.setValue(e,!1))}})(jQuery);
\ No newline at end of file
+(i=>{i(document).ready(function(){window.wu_initialize_selectizer=function(){i.each(i("[data-selectize]"),function(e,t){var t=jQuery(i(t)),a=t.find("option").length,l={};1e3<a&&(l.maxOptions=a+100),t.selectize(l)}),i.each(i("[data-selectize-categories]"),function(e,t){jQuery(i(t)).selectize({maxItems:i(t).data("max-items")||10,create(e){return{value:e,text:e}}})}),i.each(i("[data-model]"),function(e,t){wu_selector({el:t,valueField:i(t).data("value-field"),labelField:i(t).data("label-field"),searchField:i(t).data("search-field"),maxItems:i(t).data("max-items"),selected:i(t).data("selected"),options:[],data:{action:"wu_search",model:i(t).data("model"),number:10,exclude:i(t).data("exclude"),include:i(t).data("include")}})})},wu_initialize_selectizer(),jQuery("body").on("wubox:load",function(){wu_initialize_selectizer()})}),window.wu_selector=function(l){if(l=_.defaults(l,{options:[],maxItems:1,templateName:!1,create:!1}),jQuery(l.el).data("init"))return;jQuery(l.el).data("__options",l);let i=jQuery(l.el).selectize({valueField:l.valueField,labelField:l.labelField,searchField:["text","name","display_name","domain","path","title","desc","code","post_title","reference_code"],options:l.options,maxItems:l.maxItems,create:l.create,render:{option(e){var t=l.templateName||l.data.model,t=(jQuery("#wu-template-"+t).length?jQuery("#wu-template-"+t):jQuery("#wu-template-default")).html();return _.template(t,{interpolate:/\{\{(.+?)\}\}/g})(e)}},load(e,t){if(!e.length)return t();var a=jQuery(l.el).data("__options");jQuery.ajax({url:wu_selectizer.ajaxurl,type:"POST",data:{...a.data,query:{search:"*"+e+"*"}},error(){t()},success(e){d.savedItems=e,t(e)}})}}),d=(jQuery(l.el).attr("data-init",1),i[0].selectize);var e;d.on("change",function(e){var t=jQuery(i[0]),a=t.parents("[data-wu-app]").data("wu-app");a&&void 0!==window["wu_"+a]&&(window["wu_"+a][t.attr("name")]=e)}),d.on("item_add",function(a){const l=d.options[a];l&&l.url&&(window.location.href=l.url)}),l.selected&&(d.options=[],d.clearOptions(),e=_.isArray(l.selected)?l.selected:[l.selected],d.addOption(e),e=_.isArray(l.selected)?_.pluck(l.selected,l.valueField):l.selected[l.valueField],d.setValue(e,!1))}})(jQuery);
\ No newline at end of file
diff --git a/inc/class-ajax.php b/inc/class-ajax.php
index a8ef00692..53bfa8315 100644
--- a/inc/class-ajax.php
+++ b/inc/class-ajax.php
@@ -341,15 +341,41 @@ function ($item) use ($section, $section_slug) {
 			$all_fields = array_merge($all_fields, $section['fields']);
 		}
 
-		$_settings = \Arrch\Arrch::find(
+		$search_term = strtolower(trim((string) $query['search'], '*'));
+
+		/*
+		 * Filter settings that match the search term against setting_id, title,
+		 * or desc fields (case-insensitive), excluding header-type fields.
+		 * The previous implementation only searched setting_id, which meant users
+		 * could not find settings by their human-readable titles.
+		 */
+		$_settings = array_filter(
 			$all_fields,
-			[
-				'sort_key' => 'title',
-				'where'    => [
-					['setting_id', '~', trim((string) $query['search'], '*')],
-					['type', '!=', 'header'],
-				],
-			]
+			function ($item) use ($search_term) {
+
+				if (wu_get_isset($item, 'type') === 'header') {
+					return false;
+				}
+
+				$setting_id = strtolower((string) wu_get_isset($item, 'setting_id', ''));
+				$title      = strtolower((string) wu_get_isset($item, 'title', ''));
+				$desc       = strtolower((string) wu_get_isset($item, 'desc', ''));
+
+				return str_contains($setting_id, $search_term)
+					|| str_contains($title, $search_term)
+					|| str_contains($desc, $search_term);
+			}
+		);
+
+		usort(
+			$_settings,
+			function ($a, $b) {
+
+				return strcmp(
+					(string) wu_get_isset($a, 'title', ''),
+					(string) wu_get_isset($b, 'title', '')
+				);
+			}
 		);
 
 		return array_values($_settings);