From d49f2dc18b62da3bdac651773ce58c450790b8f3 Mon Sep 17 00:00:00 2001 From: Daniil Tatianin <99danilt@gmail.com> Date: Wed, 12 Mar 2025 13:07:51 -0700 Subject: [PATCH] package_manager: don't provide multiple args to shell=True This can apparently result in false positive 0 exit codes. Signed-off-by: Daniil Tatianin <99danilt@gmail.com> --- package_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package_manager.py b/package_manager.py index 4a30d37..392ff1e 100644 --- a/package_manager.py +++ b/package_manager.py @@ -5,7 +5,7 @@ def _command_exists(cmd: str) -> bool: - ret = subprocess.run(["command", "-v", cmd], stdout=subprocess.DEVNULL, + ret = subprocess.run(f"command -v {cmd}", stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, shell=True) return ret.returncode == 0