BUGFIX Make sure it's possible to rename the module's directory without ... #10

Merged
merged 1 commit into from Oct 13, 2012

Projects

None yet

2 participants

@drzax
Contributor
drzax commented Oct 1, 2012

...breaking things.

@UndefinedOffset
Owner

I've added message to make sure this doesn't happen instead

@drzax
Contributor
drzax commented Oct 13, 2012

Why not allow developers to change the name of the module directory? The note doesn't really help much with 'bug' this pull request was intended to fix.

Personally, I'm happy to maintain a fork, but I'm sure I'm not the only developer who likes to have projects arranged in a particular way. For example, I like all my modules lowercase and prefixed by developer name.

@UndefinedOffset UndefinedOffset merged commit 62e171a into UndefinedOffset:master Oct 13, 2012
@UndefinedOffset
Owner

Merged though I tweaked the constant you added so it could be used for file system paths, just in case ;). Doesn't cause any issues though since the Requirements class assumes relative paths are relative to the base url for the site anyways.

@UndefinedOffset
Owner

And thanks :)

@drzax
Contributor
drzax commented Oct 13, 2012

Great, thanks for reconsidering! And thanks for the module.

@drzax drzax deleted the lrc:bug-fix branch Jan 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment