Test suites #2

Closed
UndefinedOffset opened this Issue Mar 13, 2014 · 2 comments

Comments

1 participant
@UndefinedOffset
Owner

UndefinedOffset commented Mar 13, 2014

Should add automated testing with phpunit and behat via travis-ci

@UndefinedOffset

This comment has been minimized.

Show comment
Hide comment
@UndefinedOffset

UndefinedOffset May 5, 2014

Owner

Need to add tests for the following methods:

CodeBankSnippets::saveSnippet()
CodeBankSnippets::deleteSnippet()
CodeBankSnippets::packageRemoveSnippet()
CodeBankSnippets::addSnippetToPackage()
CodeBankSnippets::savePackage()
CodeBankSnippets::createPackage()
CodeBankSnippets::deletePackage()
CodeBankSnippets::newFolder()
CodeBankSnippets::renameFolder()
CodeBankSnippets::deleteFolder()
CodeBankSnippets::moveSnippet()

Should we add unit tests for the rest of the methods in CodeBankSnippets such as searching (as well as the auto complete), and other read methods?

Owner

UndefinedOffset commented May 5, 2014

Need to add tests for the following methods:

CodeBankSnippets::saveSnippet()
CodeBankSnippets::deleteSnippet()
CodeBankSnippets::packageRemoveSnippet()
CodeBankSnippets::addSnippetToPackage()
CodeBankSnippets::savePackage()
CodeBankSnippets::createPackage()
CodeBankSnippets::deletePackage()
CodeBankSnippets::newFolder()
CodeBankSnippets::renameFolder()
CodeBankSnippets::deleteFolder()
CodeBankSnippets::moveSnippet()

Should we add unit tests for the rest of the methods in CodeBankSnippets such as searching (as well as the auto complete), and other read methods?

UndefinedOffset added a commit that referenced this issue May 5, 2014

@UndefinedOffset

This comment has been minimized.

Show comment
Hide comment
@UndefinedOffset

UndefinedOffset May 5, 2014

Owner

After some adjustments to the tests (29883bb and 3d43821) builds are now passing on all but PostgreSQL databases https://travis-ci.org/UndefinedOffset/silverstripe-codebank/builds/24463430. We should probably address that but that will be another issue.

Unfortunately due to travis-ci not having a web server, the api endpoint test is disabled 3d43821. It would be a shame to install apache for just one test case, but should the build be switched to php 5.4 and use the built in web server for this test or just leave it omitted?

Owner

UndefinedOffset commented May 5, 2014

After some adjustments to the tests (29883bb and 3d43821) builds are now passing on all but PostgreSQL databases https://travis-ci.org/UndefinedOffset/silverstripe-codebank/builds/24463430. We should probably address that but that will be another issue.

Unfortunately due to travis-ci not having a web server, the api endpoint test is disabled 3d43821. It would be a shame to install apache for just one test case, but should the build be switched to php 5.4 and use the built in web server for this test or just leave it omitted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment