Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suites #2

Closed
UndefinedOffset opened this issue Mar 13, 2014 · 2 comments
Closed

Test suites #2

UndefinedOffset opened this issue Mar 13, 2014 · 2 comments
Labels
Milestone

Comments

@UndefinedOffset
Copy link
Owner

@UndefinedOffset UndefinedOffset commented Mar 13, 2014

Should add automated testing with phpunit and behat via travis-ci

@UndefinedOffset
Copy link
Owner Author

@UndefinedOffset UndefinedOffset commented May 5, 2014

Need to add tests for the following methods:

CodeBankSnippets::saveSnippet()
CodeBankSnippets::deleteSnippet()
CodeBankSnippets::packageRemoveSnippet()
CodeBankSnippets::addSnippetToPackage()
CodeBankSnippets::savePackage()
CodeBankSnippets::createPackage()
CodeBankSnippets::deletePackage()
CodeBankSnippets::newFolder()
CodeBankSnippets::renameFolder()
CodeBankSnippets::deleteFolder()
CodeBankSnippets::moveSnippet()

Should we add unit tests for the rest of the methods in CodeBankSnippets such as searching (as well as the auto complete), and other read methods?

UndefinedOffset added a commit that referenced this issue May 5, 2014
methods need tests (issue #2)
@UndefinedOffset
Copy link
Owner Author

@UndefinedOffset UndefinedOffset commented May 5, 2014

After some adjustments to the tests (29883bb and 3d43821) builds are now passing on all but PostgreSQL databases https://travis-ci.org/UndefinedOffset/silverstripe-codebank/builds/24463430. We should probably address that but that will be another issue.

Unfortunately due to travis-ci not having a web server, the api endpoint test is disabled 3d43821. It would be a shame to install apache for just one test case, but should the build be switched to php 5.4 and use the built in web server for this test or just leave it omitted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.