Desktop Client version miss-match when using composer #4

Closed
UndefinedOffset opened this Issue Apr 15, 2014 · 1 comment

Comments

1 participant
@UndefinedOffset
Owner

UndefinedOffset commented Apr 15, 2014

Looks like the desktop client is not very happy when using composer to manage code bank. Could be as simple as removing the check for the build date in the server-client handshake.

We should also verify the DB upgrade process is also only checking on the version number. Alternatively come up with away to include the build date in composer releases if possible or retrieve it from the composer lock file like we do the version.

@UndefinedOffset UndefinedOffset added the bug label Apr 15, 2014

@UndefinedOffset

This comment has been minimized.

Show comment
Hide comment
@UndefinedOffset

UndefinedOffset Apr 26, 2014

Owner

Looks like in the composer.lock there is a time key, I believe this is the release date so lets use that.

{
    "name": "undefinedoffset/silverstripe-codebank",
    "version": "3.0.2",
    "source": {
        "type": "git",
        "url": "https://github.com/UndefinedOffset/silverstripe-codebank.git",
        "reference": "eb9bed874fe14522e0cb9bfdbe55d717636652b5"
    },
    "dist": {
        "type": "zip",
        "url": "https://api.github.com/repos/UndefinedOffset/silverstripe-codebank/zipball/eb9bed874fe14522e0cb9bfdbe55d717636652b5",
        "reference": "eb9bed874fe14522e0cb9bfdbe55d717636652b5",
        "shasum": ""
    },
    "require": {
        "composer/installers": "*",
        "silverstripe/framework": "3.1.*"
    },
    "type": "silverstripe-module",
    "extra": {
        "installer-name": "CodeBank"
    },
    "notification-url": "https://packagist.org/downloads/",
    "license": [
        "BSD-3-Clause"
    ],
    "authors": [
        {
            "name": "Ed Chipman",
            "homepage": "http://www.edchipman.ca",
            "role": "Developer"
        }
    ],
    "description": "Code Bank is a code snippet manager with syntax highlighting for multiple languages including C++, ActionScript, Flex, HTML and SQL to name a few. Code Bank also has a simple revision history with a compare viewer so you can see the changes side-by-side between two revisions.",
    "keywords": [
        "development",
        "silverstripe",
        "snippet",
        "snippet manager"
    ],
    "time": "2014-04-13 17:48:52"
}
Owner

UndefinedOffset commented Apr 26, 2014

Looks like in the composer.lock there is a time key, I believe this is the release date so lets use that.

{
    "name": "undefinedoffset/silverstripe-codebank",
    "version": "3.0.2",
    "source": {
        "type": "git",
        "url": "https://github.com/UndefinedOffset/silverstripe-codebank.git",
        "reference": "eb9bed874fe14522e0cb9bfdbe55d717636652b5"
    },
    "dist": {
        "type": "zip",
        "url": "https://api.github.com/repos/UndefinedOffset/silverstripe-codebank/zipball/eb9bed874fe14522e0cb9bfdbe55d717636652b5",
        "reference": "eb9bed874fe14522e0cb9bfdbe55d717636652b5",
        "shasum": ""
    },
    "require": {
        "composer/installers": "*",
        "silverstripe/framework": "3.1.*"
    },
    "type": "silverstripe-module",
    "extra": {
        "installer-name": "CodeBank"
    },
    "notification-url": "https://packagist.org/downloads/",
    "license": [
        "BSD-3-Clause"
    ],
    "authors": [
        {
            "name": "Ed Chipman",
            "homepage": "http://www.edchipman.ca",
            "role": "Developer"
        }
    ],
    "description": "Code Bank is a code snippet manager with syntax highlighting for multiple languages including C++, ActionScript, Flex, HTML and SQL to name a few. Code Bank also has a simple revision history with a compare viewer so you can see the changes side-by-side between two revisions.",
    "keywords": [
        "development",
        "silverstripe",
        "snippet",
        "snippet manager"
    ],
    "time": "2014-04-13 17:48:52"
}

@UndefinedOffset UndefinedOffset added this to the 3.0.3 milestone Apr 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment