Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move basic permission checking out of each method #7

Closed
UndefinedOffset opened this issue May 4, 2014 · 0 comments
Closed

Move basic permission checking out of each method #7

UndefinedOffset opened this issue May 4, 2014 · 0 comments
Labels
Milestone

Comments

@UndefinedOffset
Copy link
Owner

@UndefinedOffset UndefinedOffset commented May 4, 2014

We should move the api's basic permission checking (permission check on CODE_BANK_ACCESS) outside of each method call and into CodeBank_ClientAPI around where it handles the request or into CodeBankAMFServer. Checks for admin permissions should remain where they however is there some other way we can also improve this? Maybe a per-class basis, if that is the case then we should move or adjust how user's change their passwords from the client.

@UndefinedOffset UndefinedOffset added this to the 3.1.0 milestone May 5, 2014
UndefinedOffset added a commit that referenced this issue Jul 5, 2014
build issues caused by #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.