New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Redesign #18

Merged
merged 9 commits into from Jul 24, 2017

Conversation

Projects
None yet
2 participants
@bgiesing
Contributor

bgiesing commented Jul 24, 2017

  • Update Bootstrap and JQuery
  • New Theme | Superhero by Bootswatch
  • Use for navbar
  • Move profile to right side of Navbar (I think this makes sense as Login buttons are usually on the right but can be reverted)
  • Merge Reddit and Discord links into dropdown (again can be reverted)

Likely needs a bit of testing to make sure everything is 100% functional. (Didn't test Canonizer at all and Dropdowns didn't work right on my machine but that could be cause Chrome DevTools modifying an already loaded page)

Plus, it might be a good idea to download the Bootstrap resources instead of using the CDN and merge/minify the two CSS files.

EDIT: Might also be good to update jQuery UI and Underscore JS but I'm not sure how backward compatible code wise the new versions are (but I know jQuery as long as it's a 1.x version is).


This change is Reviewable

bgiesing added some commits Jul 24, 2017

Update Jukebox Homepage
- Update Bootstrap and JQuery
- New Theme
- Use <nav> for navbar
- Move profile to right side of Navbar (I think this makes sense as Login buttons are usually on the right
- Merge Reddit and Discord links into dropdown
Update Jukebox Player
Same changes as Homepage
@UnderMybrella

This comment has been minimized.

Owner

UnderMybrella commented Jul 24, 2017

Looks good, and I'll have a look at the Bootstrap resources

@UnderMybrella UnderMybrella reopened this Jul 24, 2017

@UnderMybrella UnderMybrella merged commit dcdccab into UnderMybrella:rewrite Jul 24, 2017

1 of 2 checks passed

code-review/reviewable 8 files left
Details
codacy/pr Good work! A positive pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment