UI Redesign #18
Merged
UI Redesign #18
Conversation
- Update Bootstrap and JQuery - New Theme - Use <nav> for navbar - Move profile to right side of Navbar (I think this makes sense as Login buttons are usually on the right - Merge Reddit and Discord links into dropdown
Same changes as Homepage
|
Looks good, and I'll have a look at the Bootstrap resources |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Likely needs a bit of testing to make sure everything is 100% functional. (Didn't test Canonizer at all and Dropdowns didn't work right on my machine but that could be cause Chrome DevTools modifying an already loaded page)
Plus, it might be a good idea to download the Bootstrap resources instead of using the CDN and merge/minify the two CSS files.
EDIT: Might also be good to update jQuery UI and Underscore JS but I'm not sure how backward compatible code wise the new versions are (but I know jQuery as long as it's a 1.x version is).
This change is