Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search in Redmine 3.2.1 #69

Merged
merged 1 commit into from Apr 28, 2016
Merged

Conversation

dmedvinsky
Copy link
Contributor

@dmedvinsky dmedvinsky commented Apr 28, 2016

Scope lambdas in search are passed an options argument, but lambdas defined
in init.rb don't accept any arguments. Since they are lambdas, the arguments
are validated at runtime and it fails with exception. Simply changing them to
procs fixes the issue.

Related line from Redmine: https://github.com/redmine/redmine/blob/fcb4e510ea3c4de06aa7dfad31c772ad589fd612/lib/plugins/acts_as_searchable/lib/acts_as_searchable.rb#L186

Scope lambdas in search are passed an `options` argument, but lambdas defined
in `init.rb` don't accept any arguments. Since they are lambdas, the arguments
are validated at runtime and it fails with exception. Simply changing them to
lambdas fixes the issue.

Related line from Redmine: https://github.com/redmine/redmine/blob/fcb4e510ea3c4de06aa7dfad31c772ad589fd612/lib/plugins/acts_as_searchable/lib/acts_as_searchable.rb#L186
@mrPsycho mrPsycho mentioned this pull request Apr 28, 2016
@nodecarter nodecarter merged commit ca73509 into Restream:master Apr 28, 2016
@johnjaylward
Copy link

johnjaylward commented Jun 17, 2016

this appears to fix issue only searches like in #57 , but if the wiki is searched the error in #70 shows. If the wiki is disabled in the project no error occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants