Fix use of 'int' to represent 'hid_t' that caused HDF5 1.10 to fail. #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: github issue Unidata/netcdf-fortran#82 This was originally discovered in the Fortran tests, but is a problem in the C library. The problem only occurred when using HDF5-1.10.x. The reason it failed is that starting with 1.10, the hid_t type was changed from 32 bits to 64 bits. The function libsrc4/nc4memcb.c#NC4_image_init was using type int (doh!) to return the hdf fileid instead of hid_t type. This, of course, caused the id to be truncated and in turn later use of the id caused hdf5 to fail. Fix is trivial: replace int with hid_t. This also requires a related change in nc4mem.c. Also added the test case derived from the original Fortran code. You would think I would learn...
|
Thanks @DennisHeimbigner I'll get this checked and merged as soon as the CI finishes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: github issue Unidata/netcdf-fortran#82
This was originally discovered in the Fortran tests, but is
a problem in the C library.
The problem only occurred when using HDF5-1.10.x. The reason it
failed is that starting with 1.10, the hid_t type was changed
from 32 bits to 64 bits.
The function libsrc4/nc4memcb.c#NC4_image_init was using type int (doh!)
to return the hdf fileid instead of hid_t type. This, of course,
caused the id to be truncated and in turn later use of the id
caused hdf5 to fail.
Fix is trivial: replace int with hid_t. This also requires a related
change in nc4mem.c.
Also added the test case derived from the original Fortran code.
You would think I would learn...