Some small fixes for nc-config #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed in a previous commit for nc-config.cmake.in, but not for the autotools version
pkg-config isn't used in the cmake version of nc-config, so probably shouldn't be used in autotools version either?
- Add --has-fortran, in addition to the specific --has-f90, --has-f03 - Add --libdir to print just the libdir - Also 'which nf-config' will spit out errors if nf-config is not found. Silence these errors
|
Very helpful and much appreciated, thanks! Reviewing now, will merge shortly unless issues are discovered. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #235 fixed a couple of hard-coded paths in
nc-config.cmake.in. This PR fixes them innc-config.in, used by autotools. It also adds some flags which I think should be included:--libdir, by analogy with--includedir;--has-fortran, rather than the specific--has-{f90,f03}, which are only available ifnf-configis found; and the flags/libs needed for the C++ API, which can be checked withncxx{,4}-config, assuming it's been found (by analogy to the Fortran flags/libs).