Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
recognize _Encoding attribute for char and string arrays #665
Add check for
referenced this pull request
May 17, 2017
@shoyer, I'm wondering how this change would impact xarray - especially the auto-conversion of char arrays to string arrays with the last dimension collapsed. This would only happen if the
@jswhit thanks for the heads up. Yes, I think this implementation as-is would break xarray, where we do our own char -> string array conversion.
There are two ways to fix this:
I like this second option better.
The second option would be nice, but quite difficult since
How about adding a