New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix access_urls for some services #152

Merged
merged 3 commits into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@dopplershift
Member

dopplershift commented Sep 6, 2017

Catalogs are allowed to specify the name of a service that is contained
within a compound service. Siphon was not properly creating the access
urls dictionary for this case.

BUG: Fix access_urls for some services
Catalogs are allowed to specify the name of a service that is contained
within a compound service. Siphon was not properly creating the access
urls dictionary for this case.
@lesserwhirls

Looks good.

@jrleeman

One question that is more for me to understand the compound service.

service_name = metadata['serviceName']
all_service_dict = {}
for service in all_services:
all_service_dict[service.name] = service

This comment has been minimized.

@jrleeman

jrleeman Sep 6, 2017

Member

Should this be in an else? (i.e. should the compound service be in the dictionary or just it's sub services?)

@jrleeman

jrleeman Sep 6, 2017

Member

Should this be in an else? (i.e. should the compound service be in the dictionary or just it's sub services?)

This comment has been minimized.

@dopplershift

dopplershift Sep 6, 2017

Member

You want both. I initially had it as an else, and it (rightly) failed tests.

@dopplershift

dopplershift Sep 6, 2017

Member

You want both. I initially had it as an else, and it (rightly) failed tests.

This comment has been minimized.

@jrleeman

jrleeman Sep 6, 2017

Member

👍

@jrleeman

jrleeman Sep 6, 2017

Member

👍

dopplershift added some commits Sep 7, 2017

MNT: Fix conda architecture for AppVeyor
Seems that we weren't using the right variable to point to the 64-bit
conda, so we were running 32-bit conda on 64-bit platforms. Oops.
MNT: Don't ignore coverage on tests
We've asked CodeCov to track this, so we should probably no longer
ignore coverage results for the test files.

@jrleeman jrleeman merged commit e5731ad into Unidata:master Sep 11, 2017

8 checks passed

codacy/pr Good work! A positive pull request.
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project/library 97.13% (+1.48%) compared to 290d18b
Details
codecov/project/tests 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
license/cla Contributor License Agreement is signed.
Details

@dopplershift dopplershift deleted the dopplershift:fix-cat-services branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment