Don't crash when logging in users with old-style password hashes #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - This would crash in hashlib under Python 3, as password is a string, while md5 hashes require binary data. - This only crashes on long-living NAV installs where there may still be old-style password hashes on some accounts.
Because: - Leaving old-style, unsalted md5 password hashes in the database is stupid and ultimately insecure. - Active users should have their password hashes more secure. At some point in the future, we should stop supporting old-style hashes altogether.
hmpf
reviewed
Dec 4, 2019
hmpf
reviewed
Dec 4, 2019
hmpf
reviewed
Dec 4, 2019
There was a problem hiding this comment.
Seems to fix the current problem, but MD5 in (almost) 2020?
https://medium.com/@mpreziuso/password-hashing-pbkdf2-scrypt-bcrypt-and-argon2-e25aaf41598e
|
Something like this might be the smartest way to go: |
For verification of old hashes, yes. No new hashes are stored using md5. |
So, basically, hash-in-hash? :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some user accounts still have old-style password hashes in the NAV account database (meaning their password has not been changed in years!).
Under Python 3, the verification of such old-style hashes will crash during the web login phase, since a string object is fed to a
hashlibhash function that expects a bytes object.Ultimately, support for old-style password hashes should be phased out. This PR will re-hash a user's password whenever an old-style password hash is found and verified.