Vendor the PickleSerializer #2866
Merged
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmpf
force-pushed
the
vendor-session-serializer
branch
from
cdedd70 to
3d0b008
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2866 +/- ##
=======================================
Coverage 56.69% 56.70%
=======================================
Files 602 603 +1
Lines 43971 43983 +12
=======================================
+ Hits 24931 24942 +11
- Misses 19040 19041 +1 ☔ View full report in Codecov by Sentry. |
hmpf
force-pushed
the
vendor-session-serializer
branch
from
3d0b008 to
11234fb
Compare
|
hmpf
force-pushed
the
vendor-session-serializer
branch
from
11234fb to
679239a
Compare
johannaengland
approved these changes
Mar 7, 2024
hmpf
force-pushed
the
vendor-session-serializer
branch
from
679239a to
4986ee8
Compare
lunkwill42
requested changes
Mar 8, 2024
lunkwill42
approved these changes
Mar 8, 2024
hmpf
force-pushed
the
vendor-session-serializer
branch
from
fc8c564 to
2234aa7
Compare
|
If we find a good way to erase existing cookies stored with $old_serializer and forcing a new login then we can get rid of this file, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2852 and does not depend on #2828
If using
signed_cookiesas the session engine, serializing with pickle is a security problem. We do not use signed_cookies, so we can continue to use PickleSerializer.This vendored version makes the serializer incompatible with the signed_cookies engine just in case.
See also #2865