Add QR Code link to 'My Stuff' - #2897
Merged
johannaengland merged 2 commits intoAug 12, 2025
Merged
Conversation
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
May 2, 2024 13:30
b46efd6 to
cda6a53
Compare
johannaengland
marked this pull request as draft
May 2, 2024 13:30
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2897 +/- ##
==========================================
- Coverage 60.87% 60.84% -0.03%
==========================================
Files 607 607
Lines 43953 43953
Branches 48 48
==========================================
- Hits 26758 26745 -13
- Misses 17183 17196 +13
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
3 times, most recently
from
May 6, 2024 13:49
02aea42 to
459cce4
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
2 times, most recently
from
May 7, 2024 09:09
10b84e2 to
f7aedce
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
May 16, 2024 07:29
f7aedce to
667c376
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
May 16, 2024 11:30
a5951ec to
667c376
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
July 3, 2024 12:48
667c376 to
03eb2d7
Compare
|
|
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
August 7, 2024 16:18
03eb2d7 to
a0b810a
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
March 7, 2025 14:13
a0b810a to
6f988cc
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
March 10, 2025 07:14
6f988cc to
f04382a
Compare
|
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
2 times, most recently
from
July 22, 2025 13:02
8d91221 to
691c63d
Compare
johannaengland
marked this pull request as ready for review
July 22, 2025 13:06
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
July 22, 2025 13:17
691c63d to
b8fd8e5
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
3 times, most recently
from
July 28, 2025 08:34
8626c71 to
5cd052b
Compare
johannaengland
requested review from
a team
and removed request for
hmpf,
lunkwill42 and
stveit
July 28, 2025 08:35
Contributor
Author
|
I would also like to have a review from @podliashanyk before I merge this in |
podliashanyk
suggested changes
Jul 30, 2025
johannaengland
marked this pull request as draft
July 30, 2025 12:06
johannaengland
marked this pull request as ready for review
July 31, 2025 12:50
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
2 times, most recently
from
August 5, 2025 07:18
171c298 to
6e886ce
Compare
6 tasks
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
August 11, 2025 12:44
6e886ce to
3338dd3
Compare
lunkwill42
approved these changes
Aug 11, 2025
lunkwill42
left a comment
lunkwill42
left a comment
Member
There was a problem hiding this comment.
As long as @podliashanyk is satisfied with the CSS changes, so am I :)
Clicking the link will open a modal with a QR code to the current page
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
August 12, 2025 08:36
3338dd3 to
23b7cff
Compare
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent on #3386. Another part to #2586.
This adds a button to 'My Stuff' that when clicked opens a modal displaying a QR code with the link to current page. This modal can be dismissed by clicking on the "X" button or clicking outside of the modal.
Screenshots - before and after
Before:
After: