Add back missing delete icon for form selectors #2898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selector labels in forms did once have a visible delete icon (the X), not sure when they disappeared. It seems the image they refer to has never been in the NAV code under that name, even if I'm sure I've seen it work at some point.
lunkwill42
force-pushed
the
bugfix/select2-icons
branch
from
a6481f7 to
55a70a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2898 +/- ##
=======================================
Coverage 60.21% 60.21%
=======================================
Files 601 601
Lines 43981 43981
=======================================
Hits 26481 26481
Misses 17500 17500 ☔ View full report in Codecov by Sentry. |
johannaengland
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selector labels in forms did once have a visible delete icon (the X), not sure when they disappeared. It seems the image they refer to has never been in the NAV code under that name, even if I'm sure I've seen it work at some point.
Before
After