Relax permissions for API interface view endpoint - #3373
Merged
johannaengland merged 1 commit intoMay 14, 2025
Merged
Conversation
johannaengland
force-pushed
the
bugfix/interface-api-permissions
branch
2 times, most recently
from
May 14, 2025 09:56
e7cb6b7 to
6ba9030
Compare
Needed for portview of ipdevinfo tool to work for non-admin users This bug was introduced in c2b9002
johannaengland
force-pushed
the
bugfix/interface-api-permissions
branch
from
May 14, 2025 11:50
6ba9030 to
1a95fa3
Compare
johannaengland
marked this pull request as ready for review
May 14, 2025 11:52
|
lunkwill42
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c2b9002 has locked down API permissions for unprivileged users, but this lead to the port view in ipdevinfo to break for unprivileged users, since the API endpoint
api/interface/is being called to fill that view by the frontendThis PR lets unprivileged users access that endpoint again.
No tests for now, since I realized that we need functional tests to make sure that the frontend API call does not break anything. But manually tested.