Relax permissions for API list room endpoint - #3375
johannaengland merged 1 commit into
Conversation
922388c to
fc61d69
Compare
lunkwill42
left a comment
There was a problem hiding this comment.
I think I would rather see RelaxedPermission extended to also require the request operation to be a one of the "safe" operations, rather than have custom permission switching code within each view.
DRF provides a IsAuthenticatedOrReadOnly permission which nearly fits the bill. I would want RelaxedPermission to be more like a IsAuthenticatedAndReadOnly. Perhaps even have it renamed to RelaxedReadPermission.
fc61d69 to
eae26c7
Compare
eae26c7 to
6456c2e
Compare
8e6a973 to
798a05d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.13.x #3375 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Needed for room map widget This bug was introduced in c2b9002
6456c2e to
a6f8a4b
Compare
|



Dependent on #3376.
Needed for room map widget. The frontend is using the
room/API endpoint.This bug was introduced in c2b9002