Repository navigation
Replace search hint modals in Radius tool - #3494
Merged
Merged
Conversation
Test results 12 files 12 suites 12m 25s ⏱️ Results for commit 7edce01. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3494 +/- ##
==========================================
+ Coverage 60.99% 61.07% +0.08%
==========================================
Files 607 607
Lines 44435 44451 +16
Branches 43 43
==========================================
+ Hits 27101 27150 +49
+ Misses 17324 17291 -33
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Simrayz
marked this pull request as ready for review
September 2, 2025 08:02
This was referenced Sep 2, 2025
johannaengland
requested changes
Sep 3, 2025
Contributor
Author
|
@johannaengland Fixed the feedback on the URLs, and added a comment to the PR description about modal size :) |
johannaengland
approved these changes
Sep 4, 2025
Simrayz
force-pushed
the
chore/replace-radius-modals
branch
from
September 4, 2025 10:01
5d510d6 to
7edce01
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Scope and purpose
Part of #2972, based on #3454.
Uses HTMX modals to replace foundation implementation on search hints for the following tabs:
There is another usage of foundation in the Status tool, namely the #details_modal in
account_log.html.However, I do not have any test data to display at the moment, and the modal is used to display details about a given result.
Edit: 040925 10:30 (post review by @johannaengland)
Made the modals smaller to better fit the text content and increase usability. They are also using the current max size (large). The modal could be made wider by using the "fit-content" size, but a lot of long single lines of text is not very user friendly.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.