Support for Model::findAllBy$Field w/autocreating views #3

Closed
wants to merge 1 commit into
from

1 participant

@phishy

No description provided.

@gwoo gwoo commented on the diff Jan 28, 2013
tests/integration/data/CrudExtendedTest.php
$company = Companies::find($company1->id);
$data = $company->data();
$this->assertEqual('Marine Store', $data['name']);
+ $company1->delete();
@gwoo
Union of RAD member
gwoo added a line comment Jan 28, 2013

this should probably be $company->delete() instead of $company1->delete()

@phishy
phishy added a line comment Jan 28, 2013

It's the same thing.

@gwoo
Union of RAD member
gwoo added a line comment Jan 28, 2013

It may seem that way, but it is two different things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@gwoo gwoo commented on the diff Jan 28, 2013
extensions/data/source/Couchbase.php
}
- if (!empty($conditions['view'])) {
+ if (empty($conditions)) {
@gwoo
Union of RAD member
gwoo added a line comment Jan 28, 2013

Could you move this logic to the conditions method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@phishy phishy closed this Jan 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment