Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove Rules::__init() #79

Merged
merged 2 commits into from May 27, 2014

Conversation

Projects
None yet
4 participants
Contributor

warrenseymour commented Jan 1, 2014

No description provided.

Owner

nateabele commented Jan 1, 2014

Rather than have a call in the class file, it'd be better to move this to an accessor that gets initialized on first use.

Member

blainesch commented Jan 2, 2014

To get the tests to pass you'll need to update this array to ignore this "special case".

What is the purpose of this change?

Contributor

warrenseymour commented Jan 2, 2014

@blainesch - Compatibility with UnionOfRAD/lithium#985

Contributor

warrenseymour commented Jan 2, 2014

@nateabele - This is the same approach used to initialize several core classes.

Owner

nateabele commented Jan 2, 2014

I know,,, those need to change as well. One thing at a time.

jails added a commit that referenced this pull request May 27, 2014

@jails jails merged commit 3e0dc96 into UnionOfRAD:master May 27, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment