- Minor formatting. - Improve Database::_formatters docblock. - Split db value tests. - Document bypass feature in database value. - Do not import Closure class when used for doc purposes. Fully namespaced class names should be used for documentation purposes. The use block at the top is for "real" dependencies. Partially reverts 798ac5d. - Set nested list doc type for closures from closure to \Closure. - Fix type in net\http\Media::scope(). - Document test error to exception conversion. - Document filter methods. - Remove 'This method can be filtered.', default message are added in li3_docs. - Mini refactor Locale::lookup(). - Refactor Locale::_preferredAction. - Better deprecation message.
This is the 1st step in replacing `String::compare()` with the native `hash_equals()` in the future. It doesn't change behavior but makes signature and documentation more similar. - Changing order in which strings for comparison are passed to `String::compare()`. - Also clarifying documentation to indicate which string must be user-supplied and which one is known.
If the method exists it should work, if not we want to know.
In following cases `extract()` was not removed: - Many variables are extracted. Removing would cause many variables to be rewritten making the code significantly uglier. - The concept of a method relies on extract(). I.e. overwriting etc. - It seemed not safe to remove it as it was hard to trace back which variables are actually extracted. References #933.
Wrapping check in `String::insert()` in check for scalar type. Removing explicit check if object is a closure. This is implied when checking for the `__toString` on object. Closures don't have such a method. Benchmarks show this saves roughly 6% CPU time when using just strings as replacement (which is the most common usage scenario). Exposing `is_object` outside the enclosing if clause makes it eating ~10% of CPU time. Removing `is_object` may seem like an option because it is implied by `method_exists` but this turns out to be way slower for non objects. Adding note about future refactorings. Removing todo/note for optimization.
…implementing protection for the HMAC Session strategy.
… start/end elements. Fixing type-checking in `\util\String::insert()`. Adding sanity checking in `\template\Helper::_attributes()`.
…0) would always be replaced with empty strings.
…o String::insert() throws error.