Skip to content
Commits on Jan 13, 2016
  1. @davidpersson
  2. @davidpersson

    Fixing/Improving `String::compare()` algorithm; Security.

    The comparison algorithm used before wasn't really resistent against
    timing attacks. While a whole iteration was always performed, the
    loop's body would perform differently. Once `$result` was `false`,
    the right side of the condition was evaluated anymore, thus leading
    to an (albeit minimal) shorter execution time.
    
    The affected code is:
    ```
    $result = $result && ($left[$i] === $right[$i]);
    ```
    
    Refs #1259.
    davidpersson committed Sep 13, 2014
  3. @davidpersson

    Fix tests when run without E_ALL error reporting; backported.

    - Ensure needed error reporting, independent of environment settings.
    - Fixes #1247
    - Fixes #1242
    - Fixes #1250
    - Refs 702424f
    davidpersson committed Jan 3, 2016
Commits on Jan 4, 2016
  1. @davidpersson

    Remove HHVM ci.

    davidpersson committed Jan 4, 2016
  2. @davidpersson
Commits on Dec 29, 2015
  1. @davidpersson

    Turn socket tests into integration tests.

    Loose dependency on Mocker, functions weren't reliably overloaded
    when running whole test suite. Partially reverts
    77af1d5.
    
    Fixes #1243
    Fixes #1244
    davidpersson committed Dec 30, 2015
  2. @davidpersson
Commits on Dec 24, 2015
  1. @davidpersson

    Clarify message for auto init.

    Closes #1239.
    davidpersson committed Dec 24, 2015
Commits on Dec 16, 2015
  1. @davidpersson
  2. @davidpersson

    Fix test leak. Fixes #1225.

    davidpersson committed Dec 16, 2015
  3. @davidpersson
Commits on Oct 23, 2015
  1. @davidpersson

    Fix typos.

    davidpersson committed Oct 23, 2015
  2. @davidpersson

    QA

    davidpersson committed Oct 23, 2015
Commits on Sep 5, 2015
  1. @davidpersson
Commits on Sep 4, 2015
  1. @davidpersson

    QA

    davidpersson committed Sep 4, 2015
  2. @davidpersson
Commits on Sep 2, 2015
  1. @davidpersson

    Update README.

    davidpersson committed Sep 2, 2015
  2. @davidpersson

    Fix key index determination.

    Closes #1209.
    davidpersson committed Sep 2, 2015
Commits on Aug 17, 2015
  1. @davidpersson
  2. @davidpersson
  3. @davidpersson
Commits on Aug 12, 2015
  1. @davidpersson
Commits on Aug 6, 2015
  1. @davidpersson

    Improve ci setup by using mini app layout.

    - Make test resistent against differing app layouts.
    davidpersson committed Aug 6, 2015
Commits on Jul 21, 2015
  1. @davidpersson
  2. @nateabele @davidpersson

    Ensure primary record set stays in order.

    Co-auhored by David Persson
    Tests by HamidReza Koushki
    
    Closes #1189
    Refs #1162
    
    - Misc. cleanup and refactoring
    
    - Remove result caching from database iterators.
    
    - Implement `peek()`
    
    - Fix incorrectly setup tests that expected `Result` to be endless.
    
    - Finalize "forward-only" behavior in `Result`, makes rewind a noop.
      Tests updated accordingly.
    
    - Change `Result`, to eager load first result.
    
    - Fix `Result` to correctly behave when iterating over it (next
      doesn't get called before first iteration). Update all tests
      and parts that relied upon the incorrect behavior.
    
    - Refactor `RecordSet` and `Result`.
    
    - Cleanup and documentation.
    
    - Adding test to prove non-sequential record issue.
    
    - Updating has many tests to explictly use main key order.
    nateabele committed with davidpersson May 4, 2015
Commits on Jul 19, 2015
  1. @davidpersson

    Enable container based CI.

    davidpersson committed Jul 19, 2015
  2. @davidpersson

    Refactor model finders and document find.

    Removes treatment of `'all'` finder as a special case, by
    actually adding it as a finder. Normalize all finders as
    closures when being added using `finder()`.
    
    These changes reduces the amount of code
    in `find()` and cases in `__callStatic()`.
    
    Renamed to `_finders()` for clarity. Finders are a special class
    of filters. Users may not know about filters, but know of finders.
    
    Brings `_finders()` method closer to `find()` and `finder()`, where
    it is actually used.
    
    Adds thorough API documentation.
    
    Makes method static, so we can later directly call, without using $self.
    davidpersson committed Jun 21, 2015
  3. @davidpersson

    QA

    - WS
    - Remove unused param from Route::match
    - Documenation.
    - Remove dead code from Set::extract().
    - Small cleanup for Set::extract().
    - Typos.
    davidpersson committed May 30, 2015
Commits on Jul 16, 2015
  1. @davidpersson
Commits on Jul 9, 2015
  1. @davidpersson
  2. @davidpersson

    Merge pull request #1204 from DrRoach/dev

    Fixed issue where tax would pluralize to taxis not taxes.
    davidpersson committed Jul 9, 2015
  3. @DrRoach
Commits on Jun 30, 2015
  1. @kevin-jones

    Added correct singularization rule for 'sleeves' which was previously…

    … singularized to 'sleefe' incorrectly
    kevin-jones committed Jun 30, 2015
Commits on Jun 21, 2015
  1. @davidpersson
Commits on Jun 16, 2015
  1. @davidpersson
Something went wrong with that request. Please try again.