data\Entity and data\entity\Document not in sync #571

Closed
hans-d opened this Issue Jul 12, 2012 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

hans-d commented Jul 12, 2012

While working on #569 I noticed that data\Entity and data\entity\Document are not in sync, eg Document has an __unset where Entity does not. There is no docblock indicating this is by design. On entity __unset can be used to reset to default values if there is a corresponding data, otherwise unset may indeed be called.

Owner

nateabele commented Sep 15, 2012

This would be confusing, as the unset() implementation you're suggesting for Entity would mean something fundamentally different than for Document. However, I'm not opposed to a method implemented in Entity that would revert changes, or optionally reload the data from the data store.

nateabele closed this Sep 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment