Fix tests to run and pass on windows #1073

Merged
merged 1 commit into from Mar 14, 2014

Projects

None yet

3 participants

@tefra

Fix console/Request.php to be able to run tests from console on windows and fix a couple other tests that fail on windows.

@blainesch blainesch and 1 other commented on an outdated diff Mar 4, 2014
tests/cases/console/RequestTest.php
@@ -22,7 +22,7 @@ public function setUp() {
'input' => Libraries::get(true, 'resources') . '/tmp/tests/input.txt'
);
- $this->_backup['cwd'] = getcwd();
+ $this->_backup['cwd'] = ($cwd = getcwd()) ? str_replace('\\', '/', $cwd) : null;
@blainesch
blainesch Mar 4, 2014
str_replace('\\', '/', getcwd()) ?: null
@tefra
tefra Mar 7, 2014

Updated PR, thx

@nateabele nateabele merged commit e47f60f into UnionOfRAD:dev Mar 14, 2014

1 check passed

Details default The Travis CI build passed
@tefra tefra deleted the tefra:fix-tests-under-win branch Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment