$this->request->type confusion in Controller::_init #353

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

rmarscher commented Feb 22, 2012

Much thanks to @nateabele for clarifying #347. This commit simply makes it a little more obvious that Controller::_init is looking for a param named 'type' in the request object and not a mistyped instance var or method.

Basically, what happened was led to it was this -

I was looking at Controller::_init to see how I could set the _render['type'] from somewhere in the bootstrap. I saw $this->request->type, so I set $request->type = 'something' in my bootstrap, but it didn't work (because $request->params['type'] was set and I didn't realize it was taking precedence via Controller::__get()). So then I looked at lithium\action\Request and its parent classes and found that there was $_type and type() but no $type which led me to think it was a typo.

So anyway, to prevent that from happening to anyone else, I think this slight change should help make it clear.

@rmarscher rmarscher making it slightly more obvious that Controller::_init is looking for…
… a param named 'type' in the request object and not a mistyped instance var or method
4ba3b92
Member

Howard3 commented Feb 23, 2012

Closing this as it's the same as #354

Howard3 closed this Feb 23, 2012

Contributor

rmarscher commented Feb 23, 2012

Whoops... I don't remember double posting. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment