Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

$this->request->type confusion in Controller::_init #353

Closed
wants to merge 1 commit into from

2 participants

@rmarscher

Much thanks to @nateabele for clarifying #347. This commit simply makes it a little more obvious that Controller::_init is looking for a param named 'type' in the request object and not a mistyped instance var or method.

Basically, what happened was led to it was this -

I was looking at Controller::_init to see how I could set the _render['type'] from somewhere in the bootstrap. I saw $this->request->type, so I set $request->type = 'something' in my bootstrap, but it didn't work (because $request->params['type'] was set and I didn't realize it was taking precedence via Controller::__get()). So then I looked at lithium\action\Request and its parent classes and found that there was $_type and type() but no $type which led me to think it was a typo.

So anyway, to prevent that from happening to anyone else, I think this slight change should help make it clear.

@rmarscher rmarscher making it slightly more obvious that Controller::_init is looking for…
… a param named 'type' in the request object and not a mistyped instance var or method
4ba3b92
@Howard3
Collaborator

Closing this as it's the same as #354

@Howard3 Howard3 closed this
@rmarscher

Whoops... I don't remember double posting. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 22, 2012
  1. @rmarscher

    making it slightly more obvious that Controller::_init is looking for…

    rmarscher authored
    … a param named 'type' in the request object and not a mistyped instance var or method
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  action/Controller.php
View
2  action/Controller.php
@@ -144,7 +144,7 @@ protected function _init() {
$this->_render['type'] = $this->request->accepts();
return;
}
- $this->_render['type'] = $this->request->type ?: 'html';
+ $this->_render['type'] = $this->request->get('param:type') ?: 'html';
}
/**
Something went wrong with that request. Please try again.