$this->request->type confusion in Controller::_init #354

Merged
merged 1 commit into from Feb 23, 2012

Conversation

Projects
None yet
2 participants
Contributor

rmarscher commented Feb 22, 2012

Much thanks to @nateabele for clarifying #347. This commit simply makes it a little more obvious that Controller::_init is looking for a param named 'type' in the request object and not a mistyped instance var or method.

Basically, what happened was led to it was this -

I was looking at Controller::_init to see how I could set the _render['type'] from somewhere in the bootstrap. I saw $this->request->type, so I set $request->type = 'something' in my bootstrap, but it didn't work (because $request->params['type'] was set and I didn't realize it was taking precedence via Controller::__get()). So then I looked at lithium\action\Request and its parent classes and found that there was $_type and type() but no $type which led me to think it was a typo.

So anyway, to prevent that from happening to anyone else, I think this slight change should help make it clear.

making it slightly more obvious that Controller::_init is looking for…
… a param named 'type' in the request object and not a mistyped instance var or method

nateabele added a commit that referenced this pull request Feb 23, 2012

Merge pull request #354 from rmarscher/controller-request-type
$this->request->type confusion in Controller::_init

@nateabele nateabele merged commit 48801a3 into UnionOfRAD:master Feb 23, 2012

Owner

nateabele commented Feb 23, 2012

Looks like I'm gonna have to back this out, as it currently breaks some things. See here: http://travis-ci.org/#!/UnionOfRAD/lithium/builds/726396

Btw, next time do me a favor and send pull requests to the dev branch.

Contributor

rmarscher commented Feb 24, 2012

So sorry, Nate.

Owner

nateabele commented Feb 24, 2012

@rmarscher YOU SHOULD BE SORRY, THIS IS UNACCEPTABLE.

Kidding, no worries dude. That's why we have a build server. Going forward though, submit pull requests against the dev branch so we can keep master clean. Thanks man.

Owner

nateabele commented Feb 24, 2012

Oh, never mind, I already mentioned that.

Contributor

rmarscher commented Feb 24, 2012

And I already submitted a new pull to the dev branch. Thx.

Owner

nateabele commented Feb 24, 2012

Yeah, clearly I'm on top of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment