Make sure that all database columns are properly aliased when generating sql :) #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs: (1) QA fixes, (2) a test, (3) to be submitted against master. :-) |
|
Oh, sorry, I mis-spoke. It already was submitted against master, I meant dev. |
|
Also, it looks like some extra commits snuck in there related to another issue. |
| @@ -564,6 +564,7 @@ public function conditions($conditions, $context, array $options = array()) { | |||
|
|
|||
| foreach ($conditions as $key => $value) { | |||
| $schema[$key] = isset($schema[$key]) ? $schema[$key] : array(); | |||
| $key = (strpos($key, '.') !== FALSE) ? $key : ($context->alias() . "." . $key); | |||
There was a problem hiding this comment.
FALSE needs to be lowercase here and "." . $key should become ".{$key}".
Also we'll need a test case for this. Usually if you provide one along a suggested patch yourself, patches can get merged much quicker.
|
Okay, this is fixed by #482. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.