Handle timestamp values correctly Issue #28 #456

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jrgns
Contributor

jrgns commented May 13, 2012

Added correct casting of timestamp values.

Added tests for the casting.

@nateabele

This comment has been minimized.

Show comment Hide comment
@nateabele

nateabele May 14, 2012

Owner

Not sure I follow the logic on the CURRENT_TIMESTAMP/NULL one. On an insert, for example, wouldn't you need to omit the field in order for it to automatically pick up the current timestamp as its value?

Owner

nateabele commented May 14, 2012

Not sure I follow the logic on the CURRENT_TIMESTAMP/NULL one. On an insert, for example, wouldn't you need to omit the field in order for it to automatically pick up the current timestamp as its value?

@jrgns

This comment has been minimized.

Show comment Hide comment
@jrgns

jrgns May 14, 2012

Contributor

You can either omit it, or insert NULL. I didn't see an easy way to omit the field.

Contributor

jrgns commented May 14, 2012

You can either omit it, or insert NULL. I didn't see an easy way to omit the field.

@nateabele

This comment has been minimized.

Show comment Hide comment
@nateabele

nateabele May 14, 2012

Owner

Gotcha, sounds good to me. Please re-submit this patch against either the data branch or the dev branch, and I'll get it merged in. Thanks.

Owner

nateabele commented May 14, 2012

Gotcha, sounds good to me. Please re-submit this patch against either the data branch or the dev branch, and I'll get it merged in. Thanks.

@jrgns jrgns closed this May 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment