Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Optimise Model::key() and fix some issues #582

Closed
wants to merge 257 commits into from

27 participants

Simon JAILLET Dirk Brünsicke Nate Abele David M Turner Marius Justin Jenkins Michael Nitschinger Hans Donner Mehdi Lahmam Paul Huff David Persson Adam Royle Pete Holiday GWoo Léo Peltier Rob Marscher Raymond Julin Pedro Padron Davey Shafik Dan Fellars Omer Valery Vishnevskiy Mike Greiling Marc Ghorayeb and others
Simon JAILLET
Collaborator

Fix :

  • with multiples keys return null if one of them miss in the datas
  • Model::key(array()) return null instead of returning the id.

Optimisation :

  • ::to('array') is no more the default behavior for looking for key in entities
  • removing the use of method_exists()
phuff and others added some commits
Paul Huff phuff Add quotes so that directories with spaces will still work when using…
… li3 on the command line.
b44e205
David Persson davidpersson Updating docblock for `Unit::_cleanUp()`.
Moving inline documetation into method docblock.
Documenting Windows behavior.
f529905
David Persson davidpersson Fixing too long line. 5a92d99
Adam Royle ifunk Fix Unit::_cleanUp() so "app/resources/tmp/tests/empty" file is not d…
…eleted on Windows.

Signed-off-by: David Persson <davidpersson@gmx.de>
c7b08dd
David Persson davidpersson Synchronizing defaults in test `Report` and `Dispatcher`.
Changing default for `'reporter'` in `Dispatcher`.
Adding missing options documentation.
dc68018
David Persson davidpersson Changing default command header output style.
Lines will now by default be the same width as the provided text.
Updating dockblock.
Adding example to docblock.
8564937
David Persson davidpersson Initial implementation of console test progress. 952d9a5
David Persson davidpersson Changing return from `_runTestMethod()`.
Removing returning of `$passed` as this was always `null`, because the
inner function was not returning anything.

Always returning `$this->_results` as already done in the upper body of
the method in some cases.
6e7e33a
David Persson davidpersson Formatting test profiler console text output. 49b2ef1
David Persson davidpersson Correcting indentation level in profiler console output. e712701
David Persson davidpersson Removing configuration output of test command. cb66862
David Persson davidpersson Fixing usage of `$this`. 2635f93
David Persson davidpersson Making parameter in test runner optional. 65eddeb
David Persson davidpersson Refitting test reporter as progress reporter.
As in the orginal concept as of `Unit::_result()`.
This will allow to progress print after each assertion.
266559b
David Persson davidpersson Removing progress filter option. 0408339
David Persson davidpersson Explain filters option for help command. de39498
David Persson davidpersson Updating test command to use new reporter.
Dropping usage of progress filter option.
Adding verbose option and progress print mode.
17b4811
David Persson davidpersson Dropping usage of reporter in test controller. 65e0e81
David Persson davidpersson Adding exception to the expected types. b4e0099
David Persson davidpersson Updating report unit tests for new reporter. a5c014f
David Persson davidpersson Updating help command test for new test command signature. b61f594
David Persson davidpersson Skips do not have class or method info. 138e8e3
David Persson davidpersson Use verbose mode and profiler filter during CI. b8718bc
David Persson davidpersson Adding line number in verbose test command output. 553eac5
David Persson davidpersson Fixing printf template for possible strings. feec693
David Persson davidpersson Use mock in `UnitTest` do not interfer with normal test reporting.
Formatting tests.
Adding accessors for protected methods/properties in mock.
(Re)moving any helper methods used in test defined in test.
Refactoring test with precondition on expecting exceptions.
Removing repetitive assertions on backtrace data.
Adding new test for testing backtracing.
630b572
David Persson davidpersson Changing test to use uncomplicated txt format.
Updating expectation for changes to mock.
5a10e14
David Persson davidpersson Removing information about integration testing from `Unit` docblock.
There is now an `Integration` class.
5e0f613
David Persson davidpersson Revert "Changing return from `_runTestMethod()`."
This reverts commit 480a74f61eab178e95333e26f540d90f1945a3f8.

This change was interfering with the cancellation of integration test
runs thus causing existing tests to fail.
90cb2ab
David Persson davidpersson Relaxing expectation on coverage in `FilterTest`; formatting. 6d81ba6
David Persson davidpersson Updating docblock formatting f29660f
David Persson davidpersson Formatting. 3524c2d
David Persson davidpersson Removing unused assingment. 1608746
David Persson davidpersson Use non-alias version of the function for DNS resolution.
The aliased version causes timeouts ("hangs") in certain environments.
This was specifically seen on Travis CI workers. No explanation why this
behavior occurs can be given at this point.
1a382af
David Persson davidpersson Close file descriptor after opening. ad83f3a
David Persson davidpersson Revert "Use non-alias version of the function for DNS resolution."
This reverts commit 05b42ec5c1b2da642d96d057b56c99de42675cc4.

Conflicts:

	test/Unit.php
0ab31fd
David Persson davidpersson Change `Unit::_hasNetwork()` to check for A record.
Checking for ANY causes timeouts in certain environments. Especially
Travis CI worker appear to hang on the function call when using ANY.
3d9fc63
David Persson davidpersson Use non verbose mode for test output on travis. 9940ecb
David Persson davidpersson Better isolating integration test.
Prevent leaking of modifications to transliteration rules.
16e010e
David Persson davidpersson Removing subheadings from test command. 2b60429
David Persson davidpersson Reordering styles in console response. af55801
David Persson davidpersson Removing explicit return of `null`. 907943d
David Persson davidpersson Normalizing test paths trimming trailing slash. a73f55a
David Persson davidpersson Formatting error messages in test command. fbab6e4
David Persson davidpersson Updating path mapping in test command to allow non-test paths.
Expanding docblock with examples.
Updating dockblock explanation to better match functionality.
dd3b3c6
David Persson davidpersson Test command can now find and run test for a given file.
Directories aren't yet supported.
Updating docblock with example.
2d52c6a
David Persson davidpersson Removing functionless `nl()` call. 5d8113e
David Persson davidpersson Adding general OK/FAIL to end of test run. 7b7eebc
David Persson davidpersson Formatting. b31ea5f
David Persson davidpersson Fixing test failing due to latest changes in test command. e9f0952
David Persson davidpersson Differ in exit codes. 4e2771f
David Persson davidpersson Introducting plain mode for test command.
Formatting output.
52fc3a6
David Persson davidpersson Better filter files to try to map.
Removing debug code.
6e347f6
David Persson davidpersson Updating help command test for changed signature. 407f2c3
David Persson davidpersson Updating report test for moved template. 209b6c9
David Persson davidpersson Force newline on assert message. 9bbee96
David Persson davidpersson Typo. 198614a
David Persson davidpersson Adding mistakenly removed newline back. 40cdef2
David Persson davidpersson Disabling memcache extension installation on CI.
This forces tests to skip. Although the CI environment was featuring a
running Memcached it wasn't advertised and sometimes not working as
expected, causing tests to fail.

This patch can be reverted when the CI environment starts to advertise a
Memcached or such a daemon can be installed and started manually.
84c3cba
David Persson davidpersson Adding `Multibyte` class for working with UTF-8 encoded strings.
Adding tests.
Adding stress test file, creating `tests/resources`.
Adding adapters for interfacing with:
- `ext/iconv`
- `ext/intl`
- `ext/mbstring`
b7f2e08
David Persson davidpersson Adding note about UTF-8 encoded strings to `Validator`. 8a9859f
David Persson davidpersson Enabling multibyte support on `lengthBetween` validation rule.
Refs #270.
cdec5e4
David Persson davidpersson Revert "Enabling multibyte support on `lengthBetween` validation rule."
This will be re-added in a differnt way in the g11n boostrap so there's
no dependency on a class outside util.

This reverts commit eb719b636dab690168420f55853424cf9fa160c9.
1792f62
David Persson davidpersson Fixing typos and reflowing text. 4ea29af
David Persson davidpersson Fixing header typo. What happened here, dear vim? a6c9b3c
David Persson davidpersson Rewording `Multibyte` class docblock. 35f25d5
David Persson davidpersson Rewording `Multibyte` class docblock. 7b42233
David Persson davidpersson Adding multibyte support for `strpos()`, `strrpos()` and `substr()`.
Adding tests.
Modifying `Multibyte` mock adapter methods to take arbitrary number of arguments.
Reformatting tests.
Refactoring repetitive instantiation of adapter within tests.
Modifying `Intl` adapter documention on return values as per observations.
0e1f413
David Persson davidpersson Add new multibyte files to expectation. eb27068
Nate Abele nateabele Merge pull request #441 from rmarscher/entity-nested-modified
Fix To $entity->modified() For Nested Data
2c67a75
Nate Abele nateabele Merge branch 'master' into dev 4e674f8
Pete Holiday toomuchpete Adding tests for select helper int/string agnosticism f2abe3b
Nate Abele nateabele Fixing array to string conversion error on PHP 5.4. 88a2d12
Hans Donner hans-d Fix unlinking readonly files throwing an Permission denied exception …
…on Windows.

The file is checked before an unlink is tried. (this will make the tests run slower but is prefered over a if (!unlink { chmod; unlink }.
See also: http://stringoftheseus.com/blog/2010/12/22/php-unlink-permisssion-denied-error-on-windows/

Signed-off-by: Hans Donner <hans.donner@pobox.com>
3beab8c
Hans Donner hans-d simplify if else and use $item->isWritable()
Signed-off-by: Hans Donner <hans.donner@pobox.com>
59369e1
GWoo gwoo Merge pull request #478 from hans-d/fix_win_unlink
Fix win unlink
6c5ff22
Hans Donner hans-d suppressEolIssues
On linux EOL is LF, on Windows it is normally CRLF, but the latter may depend also
on the git config core.autocrlf setting. As some tests use heredoc style (<<<) to
specify multiline expectations, this EOL issue may cause tests to fail only because
of a difference in EOL's used.

in assertEqual, assertNotEqual, assertPattern and assertNotPattern this function is
called to get rid of any EOL differences.
b760352
Hans Donner hans-d simplify test for strings on _suppressEolIssues de9949e
Hans Donner hans-d _suppressEolIssues becomes _normalizeLineEndings and returns array b338b7f
Nate Abele nateabele Merge pull request #479 from hans-d/fix_win_eol
Fix win eol
00fe3a3
Hans Donner hans-d fix EOL in g11n CodeTest 9317769
Hans Donner hans-d fix EOL in g11n CodeTest the correct way 24cc20b
Nate Abele nateabele Merge pull request #450 from phuff/dev
Make it so that li3 shell script still works in directories that have spaces in the names.
0816a2b
Nate Abele nateabele Merge pull request #480 from hans-d/fix_win_eol
Fix win eol - part 2
0697150
Nate Abele nateabele Fixing broken newline assert in `Code` adapter test. 9511c05
Nate Abele nateabele Merge branch 'dev' ba0c4a2
David Persson davidpersson Applying basic coding standards conventions to CI script. d747f8c
David Persson davidpersson Restructuring CI depends script, adding docblocks. c210573
David Persson davidpersson Removing removal of executation time limit in CI depends script.
This script is supposed to be handeled by the CLI SAPI in which by
default there is no limit on the execution time.

Please see:
http://php.net/manual/en/info.configuration.php#ini.max-execution-time
e248498
David Persson davidpersson Use PHP_VERSION instead of `phpversion()` in CI depends script. 7327c99
David Persson davidpersson Refactoring retrieval of ini path in CI depends script; adding docblock. 1217042
David Persson davidpersson Adding new line above first inner class dockblock. 77a5b64
David Persson davidpersson Making CI depends script class static. 7c23779
David Persson davidpersson Adding docblock in CI depends script. d324c63
David Persson davidpersson Refactoring CI depends script. 8315029
David Persson davidpersson Fixing spacing after foreach. 936c02a
David Persson davidpersson Fixing formatting in docblocks. ba697b8
Nate Abele nateabele Testing MongoDB race condition on PHP 5.4. 593ed84
Nate Abele nateabele Testing MongoDB race condition on PHP 5.4. 74756b0
Nate Abele nateabele Making docblock for `Form::field()` less ambiguous. 55fd800
Ajai Khattri Added list showing mapping of $_schema types to MongoDb types. d6fae12
GWoo gwoo Merge pull request #487 from symbiat/master
Updated docs for Model::$_schema.
d0a11cb
Mehdi Lahmam mehlah Revamp Html helper API docs 5f16dca
Mehdi Lahmam mehlah Minor API docs updates. b7abee1
Mehdi Lahmam mehlah Minor QA fixes 07d26a0
Léo Peltier L-P Typo in comments. b05bd87
Nate Abele nateabele Revert "Handle timestamp values correctly #28"
This reverts commit e15b2100dff8dd11eeda8b5226222865dea142ae.
6f13526
Nate Abele nateabele Merge pull request #502 from L-P/patch-1
Typo in comments.
96ae2ff
Mehdi Lahmam mehlah Minor fixes c4e6436
Nate Abele nateabele Merge pull request #500 from mehlah/api-docs
Api docs
eeee1cb
Nate Abele nateabele Merge pull request #503 from mehlah/qa
Minor QA fixes
2547b36
Rob Marscher rmarscher fixed an issue with the form helper where the value zero would not di…
…splay (and a few small edits to pass lithium_qa)
d646c1f
Rob Marscher rmarscher Fixing an issue where strategies were applied to incorrect session co…
…nfigurations
606d376
Nate Abele nateabele Merge pull request #508 from rmarscher/zero-values-in-form-helper
Fixed an issue with the form helper where the value zero would not display
ddd72eb
Nate Abele nateabele Merge pull request #489 from rmarscher/session-multiple-strategies
Fixing an issue where strategies were applied to incorrect session configurations
da99ce2
Michael Nitschinger daschl WARING BC Break! Auth: adding 'persist' option to scope database fiel…
…ds. This breaks BC if you previously stored a field with the name 'password' in the session. Implements #458
9eec276
Michael Nitschinger daschl Auth: Refactoring auth persist functionality and minor qa fixes. 452564b
Raymond Julin nervetattoo Reversed direction of result / expected in test case 92e4050
Raymond Julin nervetattoo Implements Collection::reduce f583206
Nate Abele nateabele Merge pull request #527 from nervetattoo/master
Mixed up expected/result in test assertion
b737338
Nate Abele nateabele Merge pull request #528 from nervetattoo/collection-reduce
Implements Collection::reduce
2d5fd7f
Nate Abele nateabele Merge pull request #518 from daschl/auth-persist
Auth persist
9194ace
David Persson davidpersson Cleaning up and reformatting `.gitignore`.
Removing old app path ignores.
Generalizing Vim pattern.
Adding comments.
Converting to LF line endings.
c7076b8
David Persson davidpersson Fixing parsing of content types with version number. 3d4c712
Hans Donner hans-d exceptions thrown in setUp and tearDown cause silent end of testcases…
… being run

testcase for #514.
Also had to swap the lines in tesstRun to make it pass

Test case will cause silent ending on running
- /tests/cases/test
- /tests/cases/test/Dispatcher
- tests/cases/test/UnitTest
2f7f4db
Hans Donner hans-d fix SetupThrowsExceptions. This test passes already. 7455a62
Michael Nitschinger daschl QA: fixing variable names, line endings and comments. Also changing p…
…rivate methods to protected ones.
d96b165
Michael Nitschinger daschl Test: make collectLines method public in alignment to similar methods…
… in this namespace. Was intended to be public since it was lacking the _ prefix.
a715901
Hans Donner hans-d Small doc/whitespace adjustments 1af9be5
Hans Donner hans-d Merge remote-tracking branch 'upstream/dev' into fix_teardown 4c66158
Nate Abele nateabele Merge pull request #536 from hans-d/fix_teardown
On exception from tearDown pass/fail is not reported
e7f83a7
David Persson davidpersson Adding blank line after method definition. 5b8965b
David Persson davidpersson Removing assertion on test precondition. 28dc209
David Persson davidpersson Refactoring key/value header assignment. aabc90d
David Persson davidpersson Removing mistakenly added blank line. 0fd4f92
David Persson davidpersson Removing unneeded preg flag. 8a7de1b
Nate Abele nateabele Adding `composer.json`. fda5a59
Nate Abele nateabele Fixing `composer.json` syntax. f959aef
Mehdi Lahmam mehlah Minor typo fixes c443e57
Nate Abele nateabele Merge pull request #549 from mehlah/typo-fixes
Typo fixes
3f25bdf
Michael Nitschinger daschl Fleshing out composer.json with info about the project and its contri…
…butors.
84b0900
Mehdi Lahmam

what about li3 ?

Michael Nitschinger
Collaborator

I think we can add that one. The keywords are mainly used to find libraries on packagist afaik.

Nate Abele

We use the 3-clause BSD. Is it important to make the distinction here?

Collaborator

Fixed in fdeaa8e according to the "license" paragraph in https://github.com/composer/composer/blob/master/doc/04-schema.md

daschl and others added some commits
Michael Nitschinger daschl Making the license-clause more specific in composer.json fdeaa8e
David Persson davidpersson Fixing parsing of content types with version number. 6348782
Léo Peltier L-P Disable Compiler fallback by default.
I inadvertently removed my `app/resources/tmp/cache/templates` folder
and PHP was unable to write the compiled templates in it.
Instead of throwing an exception/error, the Compiler returned the
unparsed file without telling anyone what was happening (no error, no
logs).

With `$foo; ?>` appearing on the page I quickly saw that there was a
problem but if I had `short_tags` turned on, the unescaped variable
would have been printed (hello XSS!) and I would never have noticed it.

This behavior is dangerous but needed for the diagnostic page to show
properly on a default misconfigured installation of lithium. Short tags
are purposedly avoided on its template so allowing it to use the
compiler fallback is not a security/usability threat.
a8cc0cf
Léo Peltier L-P Fix EOLs. b2b3fb1
Pedro Padron ppadron making sure the default namespace used in Library::extract() is valid…
… by underscoring the directory name
796050e
Nate Abele nateabele Merge pull request #561 from ppadron/master
Making sure the default namespace used in Library::extract() is valid
1cea1c9
David Persson davidpersson Two QA fixes in test class and auth adapter.
Adding missing property declaration to test class.
Formatting empty method body.
57aa30b
GWoo gwoo Merge branch 'master' into dev dd0189f
GWoo gwoo fixing the paths for create. d414e4a
Nate Abele nateabele Making dependency checks more test-friendly in `Html` helper. 7e42ea7
Michael Nitschinger daschl Error Handler: removing old definitions and refactoring tests to refl…
…ect the change.
3e71780
Michael Nitschinger daschl Error Handler: adding better testing and assertions for error trapping be56b97
Nate Abele nateabele Merge branch 'error-handler' ed77118
GWoo gwoo Going green after #536 where test cases were added to test exception …
…handling in test cases.
d4ae2a6
GWoo gwoo Couple more changes to reflect the new tests added in #536. 6fc47ce
GWoo gwoo Merge pull request #560 from L-P/compiler-fallback-fix
Disable Compiler fallback by default.
e4ef0c2
Mehdi Lahmam mehlah Update app.phar.gz template 35602c6
Nate Abele nateabele Merge pull request #564 from mehlah/app-template
Update app.phar.gz template
fdb42c4
Mehdi Lahmam mehlah Fix the packaged app template 8621fbf
Nate Abele nateabele Merge branch 'media-asset' of git://github.com/Tomen/lithium into dev e33e5de
Nate Abele nateabele Adding test for `Media::asset()` with empty strings. 187f680
Nate Abele nateabele Merge pull request #565 from mehlah/app-template
Fix the packaged app template
7024e5a
Nate Abele nateabele Merge branch 'dev' 582210a
GWoo gwoo Adds a plain and silent option to Command.
If `--plain`, then no styles are displayed.
If `--silent`, then only error is output.
86ec504
Hans Donner

li3 test already has a --plain option, only there is used for something else

Simon JAILLET
Collaborator

Hi dashl ! This looks like similar to an recent commit in the master branch : 41ab56f. Maybe we can remove one of them ?

Collaborator

Hmm normally we push them first to dev.

Simon JAILLET

I found the golden nugget ! Do I win something ? ;-)

Collaborator

Watta hell ;)

Michael Nitschinger
Collaborator

Y U NO push to dev? ;) 5450f20

Hahaha, sorry. :-)

data/Model.php
((18 lines not shown))
}
- if (!$values) {
- return $key;
+ if (is_object($values)) {
+ if (is_string($key)) {
+ if (isset($values->{$key})) {
+ return array($key => $values->{$key});
+ } elseif (!$values instanceof Entity) {
Nate Abele Owner

This should be instanceof static::$_classes['entity'], and you can move the use declaration to $_classes. Also, I think you can rewrite this deeply nested structure to be simpler if you return home early.

Simon JAILLET Collaborator
jails added a note

Oh yeah such a big fail ! Concerning the "return home early" I already tried to flatten the deeply nested structure with no luck, everythings seems to be muddled in a way you need a least 3 nested if. Can't figure a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Simon JAILLET
Collaborator

squashed !

fellars and others added some commits
Dan Fellars fellars modified curl to support options 63a5476
Dan Fellars fellars moved statement after check for scheme/host babd627
Dan Fellars fellars fixed spacing 9a33ac7
Davey Shafik dshafik Add {:bold} style, show all docblock in help, typo ed45e5c
Mehdi Lahmam mehlah Fix wrong embedded code for Media docs examples 8e12500
GWoo gwoo Merge pull request #593 from mehlah/media-docs-typo-fix
Fix wrong embedded code for Media docs examples
9f32ba3
GWoo gwoo Merge pull request #590 from fellars/dev
modified curl to support options
ff59bc6
GWoo gwoo fix Curl tests for options setting. 94ae23b
Omer omeryar moved type check before body check 56a5ef4
Omer omeryar updated testJsonPost to test 56a5ef4
new test would have failed before
59c1780
Nate Abele nateabele Merge pull request #599 from omeryar/dev
Set request type before setting body
9cb627c
Nate Abele nateabele Merge branch 'dev' e5d7338
Nate Abele nateabele Formatting fixes. 702bb0d
Nate Abele nateabele Fixing issue with variable number of exceptions in database connectio…
…n testing.
3f38208
Nate Abele nateabele Fixing docblock conflicts. c3419a4
Mehdi Lahmam mehlah Update `composer.json` with the correct package type for Lithium libr…
…aries
e88057d
Mehdi Lahmam mehlah Composer Installers aren't yet flagged as Stable e979535
Nate Abele nateabele Fixing cases where matching routes with default values returns an emp…
…ty string.
1c12137
Nate Abele nateabele Merge pull request #606 from mehlah/composer-fix-type
Update `composer.json` with the correct package type for Lithium libraries
0809552
Valery Vishnevskiy v-v-vishnevskiy In Set::append replaced "isset" by "array_key_exists" and add support…
… for variable-length argument lists
7d514b5
Dirk Brünsicke

today i encountered an error with line 160, introduced in that commit. I do not return an user-array in my auth adapter implementation, but only the user_id. Would you mind double check, that unset will work with something like that?

if(is_array($data) && isset($data['password'])) {
    unset($data['password']);
}
Justin Jenkins

Not trying to be a hater ... but it's been a month since the last commit? Eeek.

Owner

@justinjenkins Yeah, it's called becoming a parent. ;-) Also: https://github.com/UnionOfRAD/lithium/branches

Ah, well being a father is a bit more of a commit(ment) ... like I said, not trying to be a hater ... really appreciate all your hard work on li3, use it everyday.

Owner

No worries. I actually have a bunch of work stashed locally that I've been meaning to clean up and push for the next release. Taking some time off next week to finalize that stuff, so look for a new version soon-ish.

rapzo and others added some commits
Rui Pedro M Lima rapzo Fixed the Command::nl() docblock. Method doesn't print to the output, it
builds a string and returns it.
d8f9742
Nate Abele nateabele Implementing host mapping in `\core\Environment::is()`. 7b422f4
Nate Abele nateabele Merge pull request #638 from rapzo/dev
Fixed the Command::nl() docblock. Method doesn't print to the output,
471bdd6
Nate Abele nateabele Merge branch 'master' of git://github.com/pixelcog/lithium into pixelcog 51d1770
Nate Abele nateabele Merge branch 'master' of git://github.com/v-v-vishnevskiy/lithium int…
…o v-v-vishnevskiy
ebcbb06
Nate Abele nateabele Merge branch 'cli-improvements' of git://github.com/dshafik/lithium i…
…nto dshafik
49f5692
Nate Abele nateabele Ensuring full docblocks are presented in console `Help` command for b…
…oth classes and methods. Misc. code cleanup.
c8545ff
Nate Abele nateabele Adding accessor patterns to `Libraries::get()`. b27096c
Pedro Padron ppadron Implementing return handlers in net\http\Service and adding support f…
…or $path and $data to HEAD requests. Closes #640.
1ccc1b1
Nate Abele nateabele Merge pull request #641 from ppadron/dev
Return handlers in net\http\Service and support for $path and $data in HEAD requests
5f3c105
Mehdi Lahmam mehlah Update phar-packaged app layout. d593121
Nate Abele nateabele Merge pull request #646 from mehlah/lithium-app-phar
Update phar-packaged app layout.
ddc1dc1
Eric Cholis ericcholis Extend Request.php to include Http Proxy support
Extended Request.php to allow for configurable Http Proxy support when using 'context' format. See http://www.php.net/manual/en/function.stream-context-create.php#92586
7052580
Nate Abele nateabele Fixing up proxy support implementation for `\net\http\Request`, and a…
…dding test cases.
d42184c
Pedro Padron ppadron Data for PATCH requests in net\http\Service should be encoded in the …
…request body. Fixes #647.
2576ec8
Nate Abele nateabele Merge pull request #648 from ppadron/dev
Data for PATCH requests in net\http\Service should be encoded in the request body. Fixes #647.
b5e4c87
Pedro Padron ppadron Adding net\http\Service::patch() method. d0491b6
Pedro Padron ppadron Setting correct Content-Type for PATCH requests in net\http\Request. c49de93
Nate Abele nateabele Merge pull request #649 from ppadron/dev
Services::patch() method + Content-Type fix in net\http\Request for PATCH
d35f656
Yitzchak Schaffer yitznewton From Controller, look for view in own library
To this point, li3 defaults to app/views. With this change, li3 looks by
default in libraries/foo/views/, where foo is the library containing the
Controller.

remove newlines at EOF
a29012a
Nate Abele nateabele Merge pull request #650 from yitznewton/dev
From Controller, look for view in own library
1d6fae0
Nate Abele nateabele Supporting additional HTTP response codes, and correctly distinguishi…
…ng between 406 and 415, `Media::handlers()` is public now.
becc3b6
Nate Abele nateabele Allowing `Environment::set()` to assign to multiple environments. 73a07d8
Dirk Brünsicke d1rk allow auth adapters to return a single value instead of arrays 2110acd
Dirk Brünsicke d1rk allow dispatching of unknown methods to redis connection object 5ffd4da
Nate Abele nateabele Merge pull request #655 from d1rk/auth-array-scalar
allow auth adapters to return a single value instead of arrays
28c5ee3
Nate Abele nateabele Merge pull request #656 from d1rk/redis-method-dispatch
allow dispatching of unknown methods to redis connection object
06fc157
Dan Fellars fellars added support for PUT to add body in Curl with tests afb3e15
Rui Pedro M Lima rapzo Fixed typo: Set::insert() to String::insert() in String::clean()
docblock.
7e68c17
Nate Abele nateabele Merge pull request #659 from rapzo/dev
Fixed typo
9432658
Nate Abele nateabele First pass at disambiguating request/response content type. WARNING: …
…BC break - going forward, usage of the `$type` instance property should be replaced with the `type()` method.
854171d
GWoo gwoo WARNING: BC break. Use `type` method. to properly set Content-Type on…
… all Request/Responses.

Message bodies automatically encoded/decoded for convenience.
0121ca5
GWoo gwoo Fixing up some more failing tests related to `type()` changes. 13a1e45
GWoo gwoo Making Service delete return the empty body again. 62ad34d
GWoo gwoo Adding test for encoded messages in \action\Response.
Reorganizing some tests to make it clearer what is tested.
4b33020
GWoo gwoo Merge pull request #662 from UnionOfRAD/request-response
WARNING: BC break. Request and Response refactor usage of type()
2c0485c
Nate Abele nateabele Ensuring proper casing for Location header in `\action\Response::_ini…
…t()`.
8306219
Nate Abele nateabele Ensuring request method is not improperly overwritten in `\action\Req…
…uest`.
5e0ad63
Marius

There is small problem, that now controller tries to pull the layout also from library. Before this change I was constantly told, that this feature is unneeded. Now it's implemented into core.

It should look for the view in the library, then for a layout in the library, but if it does not find one, take the one from app.

David M Turner

Is this (and the next 2 asserts) not hardcoded with the path that the library would be in, if it is tested stand-alone?

All tests pass if I run them from the cli on just the library. If I run the tests through the web interface, in an app context, testCustomAssetUrls() fails on all three asserts.

e.g.

expected: 'http://static.cdn.com/lithium/js/foo.js'
result: 'http://static.cdn.com/app/js/foo.js'

Owner

@davidmturner Ah, good call. Yes, the test assumes it's being run from the docroot, so we'll have to control for that in the test. Can you do me a favor and open an issue so we don't lose track of it?

jails and others added some commits
Dirk Brünsicke

Any reasons why this is not merged?

Nate Abele
Owner

@d1rk Because it includes deeply-nested control structures, and breaks the per-method cyclomatic complexity limit.

Dirk Brünsicke

@nateabele thanks for the info, good to know.

Simon JAILLET jails closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.