Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Curl Option support for Curl Socket #587

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

fellars commented Jul 18, 2012

can now pass curl options in either the Socket configuration array or the array passed to open function via an 'options' key inside either array (open parameter data takes precedence if collision).

Test cases provided for both scenarios in CurlTest cases.

Downside still remaining that anything passed directly via ->set() call prior to ->open() call will get deleted.

Another way around this would be to change the call to reset option which happens in first line of open() method and put that in the close() method so reset happens when connection closes instead of when opened. I didn't want to go there as some may be dependent on open() implementation.

Dan Fellars modified Curl socket to allow for setting Curl options in either the …
…Socket configuration or the parameter passed to open method via an options key
d9a5f59
Owner

nateabele commented Jul 19, 2012

Yeah, the spacing is definitely off, but as to the API changes, @gwoo should probably take this one.

Contributor

fellars commented Jul 19, 2012

My editor must change tabs to 4 spaces. I'll fix tonight.

This approach was actually gwoo's suggestion via irc :)

On Jul 18, 2012, at 7:28 PM, Nate Abelereply@reply.github.com wrote:

Yeah, the spacing is definitely off, but as to the API changes, @gwoo should probably take this one.


Reply to this email directly or view it on GitHub:
#587 (comment)

Contributor

jails commented Jul 19, 2012

Ok cool ! Just a last thing ! If you can redo this PR on dev instead of master, it'll be awesome !

@fellars fellars closed this Jul 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment