Skip to content

cleaned up spacing #588

wants to merge 12 commits into from

5 participants

fellars commented Jul 19, 2012

No description provided.

L-P and others added some commits Jun 29, 2012
@L-P L-P Disable Compiler fallback by default.
I inadvertently removed my `app/resources/tmp/cache/templates` folder
and PHP was unable to write the compiled templates in it.
Instead of throwing an exception/error, the Compiler returned the
unparsed file without telling anyone what was happening (no error, no

With `$foo; ?>` appearing on the page I quickly saw that there was a
problem but if I had `short_tags` turned on, the unescaped variable
would have been printed (hello XSS!) and I would never have noticed it.

This behavior is dangerous but needed for the diagnostic page to show
properly on a default misconfigured installation of lithium. Short tags
are purposedly avoided on its template so allowing it to use the
compiler fallback is not a security/usability threat.
@L-P L-P Fix EOLs. b2b3fb1
@daschl daschl Error Handler: removing old definitions and refactoring tests to refl…
…ect the change.
@daschl daschl Error Handler: adding better testing and assertions for error trapping be56b97
@nateabele nateabele Merge branch 'error-handler' ed77118
@gwoo gwoo Merge pull request #560 from L-P/compiler-fallback-fix
Disable Compiler fallback by default.
@nateabele nateabele Merge branch 'dev' 582210a
@nateabele nateabele Fixing `g11n\Multibyte` to prevent configuration from leaking globally. b38b11f
@nateabele nateabele Merge branch 'dev' 1a83c2b
@nateabele nateabele Cleaning up coding standards issues. 41ab56f
Union of RAD member
daschl commented on 41ab56f Jul 15, 2012

Y U NO push to dev? ;) 5450f20

Union of RAD member

Hahaha, sorry. :-)

fellars added some commits Jul 18, 2012
@fellars fellars modified Curl socket to allow for setting Curl options in either the …
…Socket configuration or the parameter passed to open method via an options key
@fellars fellars cleaned up spacing c98557a
Union of RAD member

Looks like GitHub ate your homework. :-/

Maybe try re-doing the work against a clean branch, and squash your cleanup commits.

@nateabele nateabele closed this Jul 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.