modified curl to support options #590

Merged
merged 3 commits into from Jul 22, 2012

Conversation

Projects
None yet
3 participants
@fellars
Contributor

fellars commented Jul 19, 2012

now able to add options to curl via the config array or via function parameter

@nateabele

This comment has been minimized.

Show comment
Hide comment
@nateabele

nateabele Jul 19, 2012

Member

Looks good to me. @gwoo?

Member

nateabele commented Jul 19, 2012

Looks good to me. @gwoo?

@gwoo

View changes

net/socket/Curl.php
@@ -59,6 +60,9 @@ public function open(array $options = array()) {
parent::open($options);
$config = $this->_config;
+ if (!empty($config['options'])){

This comment has been minimized.

@gwoo

gwoo Jul 19, 2012

Contributor

This should probably happen after the schema and host are checked.

@gwoo

gwoo Jul 19, 2012

Contributor

This should probably happen after the schema and host are checked.

This comment has been minimized.

@nateabele

nateabele Jul 19, 2012

Member

Oh yeah, also, coding standards.

@nateabele

nateabele Jul 19, 2012

Member

Oh yeah, also, coding standards.

This comment has been minimized.

@fellars

fellars Jul 20, 2012

Contributor

@gwoo - moved to below
@nateabele - sorry, I went through coding standards and not sure what I'm doing wrong there. I fixed the tab vs. 4-spaces issue (I think)

@fellars

fellars Jul 20, 2012

Contributor

@gwoo - moved to below
@nateabele - sorry, I went through coding standards and not sure what I'm doing wrong there. I fixed the tab vs. 4-spaces issue (I think)

This comment has been minimized.

@nateabele

nateabele Jul 20, 2012

Member

There should be a space between ) and {. Looks good otherwise.

@nateabele

nateabele Jul 20, 2012

Member

There should be a space between ) and {. Looks good otherwise.

This comment has been minimized.

@fellars

fellars Jul 20, 2012

Contributor

Ah, learned something new :)

Fixed.

@fellars

fellars Jul 20, 2012

Contributor

Ah, learned something new :)

Fixed.

gwoo added a commit that referenced this pull request Jul 22, 2012

Merge pull request #590 from fellars/dev
modified curl to support options

@gwoo gwoo merged commit ff59bc6 into UnionOfRAD:dev Jul 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment