Fix for Set::append #615

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

v-v-vishnevskiy commented Aug 21, 2012

In Set::append replaced "isset" by "array_key_exists" and add support for variable-length argument lists

This pull request passes (merged 7d514b5 into c3419a4).

Owner

nateabele commented Aug 30, 2012

There are a couple of coding standards issues here, i.e. there shouldn't be a space after !, and elseif shouldn't be on a new line. See https://github.com/UnionOfRAD/li3_qa for more. Once the CS issues are addressed, we'll get this merged in. Thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment