Fix in casting query conditions #617

Merged
merged 3 commits into from Aug 28, 2012

Conversation

Projects
None yet
4 participants
@nealerickson
Contributor

nealerickson commented Aug 24, 2012

Fixed bug in the processing of query conditions. If a condition key includes the table alias then the schema is not used determining how to cast the value. This becomes problematic when dealing with numerical values stored as strings, such as zipcodes. Without consulting the schema the values are treated as integers and the leading zeros are dropped.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Aug 24, 2012

This pull request passes (merged 198523c into baa62ee).

This pull request passes (merged 198523c into baa62ee).

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Aug 24, 2012

This pull request passes (merged 9e9945c into baa62ee).

This pull request passes (merged 9e9945c into baa62ee).

@Ciaro

This comment has been minimized.

Show comment Hide comment
@Ciaro

Ciaro Aug 24, 2012

Contributor

Stop spamming, Travis >.<

Contributor

Ciaro commented Aug 24, 2012

Stop spamming, Travis >.<

@nealerickson nealerickson reopened this Aug 28, 2012

nateabele added a commit that referenced this pull request Aug 28, 2012

Merge pull request #617 from nealerickson/data
Fix in casting query conditions

@nateabele nateabele merged commit 884e839 into UnionOfRAD:data Aug 28, 2012

1 check was pending

default The Travis build is in progress
Details
@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Aug 28, 2012

This pull request passes (merged 9e9945c into baa62ee).

This pull request passes (merged 9e9945c into baa62ee).

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Aug 28, 2012

This pull request fails (merged 275e1bc into baa62ee).

This pull request fails (merged 275e1bc into baa62ee).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment