Fix the `'joined'` strategy of `data\source\Database` to allow also non string field. #761

Merged
merged 1 commit into from Jan 5, 2013

3 participants

@jails
Union of RAD member

No description provided.

@blainesch
Union of RAD member

How do you keep track of your "pr{:id}" branches? Especially when you reuse them? Wouldn't it be easier to do "feature/joinStringFieldDb" or something then simply delete it after?

@jails
Union of RAD member

I don't understand. Once a PR is merged we need to keep a track of it on the fork's repo ?

@nateabele nateabele and 1 other commented on an outdated diff Dec 21, 2012
tests/cases/data/source/DatabaseTest.php
@@ -1506,7 +1506,7 @@ public function testCustomField() {
$query = new Query(array(
'type' => 'read',
'model' => $this->_gallery,
- 'fields' => array('count(Image.id) as count', 'Image'),
+ 'fields' => array((object)'count(Image.id) as count', 'Image'),
@nateabele
Union of RAD member

Should be a space after (object), I think. @BlaineSch Care to patch .travis.yml to enable our new-and-improved QA checker? :-)

@blainesch
Union of RAD member

When I ran it against lithium core there were already a few syntax checks that would need to be fixed. It's definitely on my todo list! :D

Being a new dad, I'm sure you can relate to the lion king "There's more to do than can ever be done".

@nateabele
Union of RAD member

Dump the list into an issue. We can tackle them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@nateabele
Union of RAD member

Yeah, 👍 on meaningful branch naming. Makes for better merge messages, thus a better commit log. @BlaineSch Maybe this is something we should add to the contributor guide? I'm open to suggestions on branch naming.

@blainesch
Union of RAD member

@nateabele The rule I've followed was either start with "bug/" or "feature/" to easily identify it then following it with something similar to variable names but for your branch... short and meaningful? (and of course camelBack.. same rules as variables, right? ^_^)

@jails
Union of RAD member

Finding a short descriptive title is already a headache for me. I'm not sure a "abstracted camelBack variable" will bring the expected information. Maybe the first namespace level ?
feature/data
bug/util
bcbreak/g11n

@blainesch
Union of RAD member

I'm not sure I'd agree with that, you could easily modify files in various namespaces and the commit log history would be flooded would duplicate looking merges.

@nateabele nateabele merged commit 0e541a4 into UnionOfRAD:dev Jan 5, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment