Making Unit return the value of the asserted Expresion consistently #768

Merged
merged 1 commit into from Dec 26, 2012

Conversation

Projects
None yet
3 participants
@coogle
Contributor

coogle commented Dec 26, 2012

No description provided.

gwoo added a commit that referenced this pull request Dec 26, 2012

Merge pull request #768 from coogle/return-asserts
Making Unit return the value of the asserted Expresion consistently

@gwoo gwoo merged commit 204b797 into UnionOfRAD:dev Dec 26, 2012

1 check passed

default The Travis build passed
Details
@nateabele

This comment has been minimized.

Show comment Hide comment
@nateabele

nateabele Dec 26, 2012

Owner

I'm not totally opposed to this, but having if blocks in unit tests is actually bad practice. The standard pattern for skipping tests based on a condition is using skipIf(), which has method-level granularity, and of which there are several examples in the core.

Owner

nateabele commented Dec 26, 2012

I'm not totally opposed to this, but having if blocks in unit tests is actually bad practice. The standard pattern for skipping tests based on a condition is using skipIf(), which has method-level granularity, and of which there are several examples in the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment