Update parser to recognize newlines when PHP does not provide a line #770

Merged
merged 1 commit into from Dec 28, 2012

Conversation

Projects
None yet
2 participants
Member

blainesch commented Dec 28, 2012

For instance the content '}' has no PHP token, so if it is the only thing on a line it'll inherit the line of it's parent line which would be incorrect.

Update parser to recognize newlines when PHP does not provide a line
For instance the content '}' has no PHP token, so if it is the only thing on a line it'll inherit the line of it's parent line which would be incorrect.
Member

blainesch commented Dec 28, 2012

Is it possible to have this cherry-picked into master as a hotfix? This is breaking some logic in one of the li3_quality rules where I'm pulling tokens by line number.

Owner

nateabele commented Dec 28, 2012

No, but we can merge dev to master.

nateabele added a commit that referenced this pull request Dec 28, 2012

Merge pull request #770 from BlaineSch/bug/parserLineFix
Update parser to recognize newlines when PHP does not provide a line

@nateabele nateabele merged commit 7f6da57 into UnionOfRAD:dev Dec 28, 2012

1 check passed

default The Travis build passed
Details
Member

blainesch commented Dec 28, 2012

@blainesch blainesch deleted the blainesch:bug/parserLineFix branch Dec 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment