Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixing typo according to li3_quality. #809

Merged
merged 1 commit into from

3 participants

@jails
Collaborator
  • fixing typo according to li3_quality.
  • comparison are done when possible with strict operator (i.e === / !==)
  • disable li3_qualtity in travis

Would be fine to reenable li3_quality only when it'll be able to pass all the core (this way PR won't need to be contaminated with typos stuff).

PS: li3_quality should pass (or almost pass imo) once this PR merged since currenlty it's not the case.

@blainesch
Collaborator

:+1:

li3_quality should stay in travis but should be refactored to run against the entire library. li3 quality syntax --library=lithium

@nateabele
Owner

This is awesome! Thanks @jails. I think we should go ahead and merge this now, and update #807 accordingly, because doing it the other way around would probably be a lot more tedious. And we can always merge li3_quality back in once everything's sorted. I wanna get this stuff into dev and get dev into master (today if we can), and then we can come back to that.

Any objections?

@blainesch
Collaborator

+1 I'll kill my quality commit.

@jails
Collaborator

It's a shame travis is offline for maintenance, but all the tests passed locally.

@nateabele nateabele merged commit f6f3cf9 into UnionOfRAD:dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 31, 2013
  1. @jails
Something went wrong with that request. Please try again.