Skip to content

Adding filter inheritance #989

Closed
wants to merge 2 commits into from

3 participants

@joebeeson
Union of RAD member

No description provided.

@jails
Union of RAD member
jails commented Jul 19, 2013

Wow this is a branch of the ancient world !
Ok just rebased the filter-inheritance branch to the last dev to have an operational travis.yml. Sorry I did a rebase to have all commits related to this concern at a "same place" (this mean a force push). So you will need to do something like this:

git fetch upstream #<- or the name you called the UnionOfRAD/lithium remote repo
git branch -m filter-inheritance filter-inheritance-old
git checkout -b filter-inheritance upstream/filter-inheritance
git cherry-pick 5c97fb62b496892372c4c4d807c5ea1dfdb07e99
git branch -D filter-inheritance-old

Otherwise looks like the tests doesn't pass & the indent is messed up ;-)

And FYI the travis build is here : https://travis-ci.org/UnionOfRAD/lithium/builds/9260436

@joebeeson
Union of RAD member

Gah that damn indention. I'll try to get to this (and the others) tonight. Thanks for your help!

@davidpersson davidpersson added the rfc label May 4, 2014
@davidpersson
Union of RAD member

Thanks for the PR. But I have to close this as it would make filters run twice in certain cases. This would not be controllable.

class A {
  function foo() {
     Filters::run(__CLASS__, ...);
  }
}

class B extends A {
  function foo() {
    parent::foo();
    Filters::run(__CLASS__, ...);
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.