Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Modified Mongo tests to skip if not enabled. #991

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Member

joebeeson commented Jul 19, 2013

Resolves issue #937

Contributor

jails commented Jul 19, 2013

Looks like the indentation is broken and needs to be opened against the dev branch, overwise it's fine.

Owner

nateabele commented Jul 19, 2013

This test should actually run regardless. Is there a problem with a dependence on Mongo?

Member

joebeeson commented Jul 21, 2013

The test fill throw a fatal error if it's run and the user does not have the Mongo extension. If this is an expected requirement of Lithium, I wasn't aware of it.

Contributor

jails commented Jul 21, 2013

Yeah It's not a requirement but since all tests are mocked it shouldn't fail.

Contributor

jails commented Jul 21, 2013

Ok just looking at tests and you're right, I didn't notice DocumentSet also do some casting tests based on source\mongo_db\Schema. I'll provide the PR for this.

@jails jails closed this Jul 21, 2013

nateabele added a commit that referenced this pull request Jul 22, 2013

Merge pull request #994 from jails/refactor/make-mongo-optional-for-t…
…ests

Skip tests which require Mongo if Mongo is not installed (close #991).

@joebeeson joebeeson deleted the joebeeson:937-mongo branch Jul 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment